Closed (fixed)
Project:
Drupal core
Version:
8.1.x-dev
Component:
Seven theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
11 Sep 2015 at 11:01 UTC
Updated:
23 Feb 2016 at 10:34 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
irina.rozite commentedFiIe tour.theme.css has been already moved to the Seven theme. I assume it was done in some other issue, but probably file should be renamed to tour.css
Comment #3
irina.rozite commentedAdded patch
Comment #10
hog commentedRerroled patch.
Comment #11
hog commentedRerroled patch.
Comment #13
andypostthat hardly overrides, are you sure that needed?
Comment #14
hog commentedComment #16
hog commentedRe-rolled path.
Comment #17
hog commentedComment #20
hog commentedApplayed patch for new 8.0.x
Comment #22
andypostDifferent approach - tour theme should be added from seven theme only when tour module enabled
Related CR https://www.drupal.org/node/2497313
the module should not care about themes at all
I think this file should be attached conditionally when tour module enabled
so better to use hook_library_info_alter() in seven theme instead of library_extend
Comment #23
hog commentedStyles moved to seven theme, all ok as i see.

Comment #24
star-szrThis could use a title and issue summary update since it's not really doing what is described, it's just changing Seven's tour CSS to load more conditionally.
Comment #25
andypostComment #27
star-szrSince this is an optimization of when the tour CSS is loaded I don't think it makes sense to commit to 8.0.x. Also, the risk is low in committing to 8.1.x because the only selectors in Seven's tour.theme.css are from joyride.
Committed 8d48a88 and pushed to 8.1.x. Thanks!
Comment #28
wim leersYes!
libraries-extendsaves the day once again :)