Problem/Motivation

Follow-up to #2565887: Fix test failures stemming from Dynamic Page Cache

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 2566537-cache-7.patch2.69 KBtim.plunkett
#2 2566537-route-cache-2.patch8.78 KBtim.plunkett
#2 interdiff.txt4.02 KBtim.plunkett
#2 2566537-route-cache-2-refactoring-only.patch6.13 KBtim.plunkett

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Disabling or deleting a page does not clear the per-route dynamic page cache » Disabling or deleting an overridden page does not clear the per-route dynamic page cache
Issue tags: +Needs tests
StatusFileSize
new 2566537-route-cache-2-refactoring-only.patch6.13 KB
new interdiff.txt4.02 KB
new 2566537-route-cache-2.patch8.78 KB

Split this into two hunks. First is the refactoring, second is the fix for disabling. Not yet working for deleting.
Also needs web tests.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Shouldn't we be able to clear the 'page_manager_page:' . $path->id() cache tag rather than having to look up the route name? Because it's the same cache entry's that'll get removed (assuming I understand how that works correctly). Or is it a render cache entry that isn't tagged with the page manager page? (And if so, where could that be coming from?)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Yes, if we make sure that the response has the page_manager cache tag, then delete should just work. Which is already the case for block display variant, we'll have to do it for the response object too. Which might need a custom one, since we have that additional response interface now.

Or actually, that should work too, through the 4xx-response cache tag, that is invalidated on every entity save?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

the 4xx-response cache tag, that is invalidated on every entity save

Oh duh, that's why I couldn't get this to break in tests, it was just using the HTTP status variant!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: -Needs tests
StatusFileSize
new 2566537-cache-7.patch2.69 KB

Hm, now I can't reproduce this at all. Is there something wrong with my test?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Needs work

Not sure what happened here, need to revisit or close out.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Closed (outdated)

Page Manager 8.x-1.x is no longer supported, closing.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.