we want to make sure certain things happen in salesforce_push_process_soap_results() no matter what.
delegating critical functionality to module_invoke can be risky.
move critical functionality out of a hook implementation.

CommentFileSizeAuthor
#2 salesforce-refactor_push_success_fail_hooks-2565871.patch2.49 KBaaronbauman

Comments

aaronbauman created an issue. See original summary.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Needs review
StatusFileSize
new salesforce-refactor_push_success_fail_hooks-2565871.patch2.49 KB
tauno’s picture

tauno commented

Should similar success and failure hooks be fired on success with non-SOAP activity as well? Probably good to be consistent if we can.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs review » Needs work

Yeah, you know I was thinking it would be really great if we could combine the push procedures even further, so that we didn't need separate hooks for soap and rest.
In the interim, rest should probably have invoke duplicate hooks.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs work » Closed (won't fix)

7.x is no longer supported

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.