In maintenance-task-list.html.twig there is a string which can't be translated since it doesn't go through the t filter.
It means that the string can't be translated for the end users.
It would be nice to fix it. :)

Files: 
CommentFileSizeAuthor
#4 2565739-after.png103.63 KBDuaelFr
#4 2565739-before.png92.26 KBDuaelFr
#2 2565739-Core-hardcoded_string-2.patch549 bytesArtusamak
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 111,844 pass(es). View

Comments

Artusamak created an issue. See original summary.

Artusamak’s picture

Status: Active » Needs review
FileSize
549 bytes
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 111,844 pass(es). View

Here is a fix for that!

cilefen’s picture

Title: Hardcoded string » maintenance-task-list contains an untranslatable, hardcoded string
Issue tags: +translation, +Twig
DuaelFr’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
92.26 KB
103.63 KB

Steps to test:

  1. Install drupal HEAD unpatched in french so it downloads the translations (you can stop the process at the database settings screen)
  2. During the installation, check the hidden title of the installation tasks on the left
  3. Drop the database if you went to the end of the first install
  4. Edit sites/default/files/translations§drupal-8.0.0-dev.fr.po
  5. Add the following at the end of the file
    msgid "Installation tasks"
    msgstr "THIS IS A TRANSLATION TO PROVE THE 2565739 PATCH IS WORKING"
  6. Apply the patch
  7. Reinstall drupal in french
  8. Re-check the hidden title of the installation tasks on the left

Before:

After:

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 2c2042f and pushed to 8.0.x. Thanks!

  • alexpott committed 2c2042f on 8.0.x
    Issue #2565739 by Artusamak: maintenance-task-list contains an...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.