If a node is part of a translation set and then updated to language neutral, then the "tnid" property is still set on the language neutral node. The logic in translation_language_switch_links_alter() incorrectly treats this node as a translated node since it checks for tnid before checking if the node is language neutral.

CommentFileSizeAuthor
#4 drupal-7.x-translation_language_switch_links_alter-und-2565705-4.patch1.62 KBrecrit
#3 drupal-7.x-translation_language_switch_links_alter-und-2565705-1.patch1.55 KBrecrit

Comments

recrit created an issue. See original summary.

recrit’s picture

recrit commented
Issue summary: View changes
recrit’s picture

recrit commented
Status: Active » Needs review
StatusFileSize
new drupal-7.x-translation_language_switch_links_alter-und-2565705-1.patch1.55 KB

The attached patch rearranges the logic to check for node existence, language neutral and language supported type before the "tnid" check.

recrit’s picture

recrit commented
StatusFileSize
new drupal-7.x-translation_language_switch_links_alter-und-2565705-4.patch1.62 KB

Updated comments to better reflect logic blocks.

recrit’s picture

recrit commented

The last submitted patch, 3: drupal-7.x-translation_language_switch_links_alter-und-2565705-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: drupal-7.x-translation_language_switch_links_alter-und-2565705-4.patch, failed testing.

recrit’s picture

recrit commented

Work needed - determine if failed tests are an issue or if they just need updated to accommodate the changes.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.