Function revisioning_node_access_records_alter causing clearing cache for All nodes instead of specified.

We shouldn't use $reset = TRUE in for function node_load. Better to set expected revision id.

$current_node = node_load($node->nid, $node->current_revision_id);

CommentFileSizeAuthor
#7 revisioning-prevent-clear-node-cache-2565681-6.patch680 bytesvtkachenko
#5 revisioning-prevent-clear-node-cache-2565681-4.patch680 bytesvtkachenko
#2 revisioning-prevent-clear-node-cache-2565681-1.patch788 bytesvtkachenko

Comments

vtkachenko created an issue. See original summary.

vtkachenko’s picture

vtkachenko commented
StatusFileSize
new revisioning-prevent-clear-node-cache-2565681-1.patch788 bytes

Please review my patch.

vtkachenko’s picture

vtkachenko commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: revisioning-prevent-clear-node-cache-2565681-1.patch, failed testing.

vtkachenko’s picture

vtkachenko commented
Status: Needs work » Needs review
StatusFileSize
new revisioning-prevent-clear-node-cache-2565681-4.patch680 bytes

Recreated patch.

Status: Needs review » Needs work

The last submitted patch, 5: revisioning-prevent-clear-node-cache-2565681-4.patch, failed testing.

vtkachenko’s picture

vtkachenko commented
Version: 7.x-1.0-beta11 » 7.x-1.9
StatusFileSize
new revisioning-prevent-clear-node-cache-2565681-6.patch680 bytes
vtkachenko’s picture

vtkachenko commented
Status: Needs work » Needs review
rdeboer’s picture

rdeboer
Location Melbourne
commented

Thanks vtkachenko -- makes total sense.
Rik

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +Performance
Parent issue: » #2680413: Plan for Revisioning 7.x-1.10 release
Related issues: +#2382331: The entity cache is not reset after publishing a pending revision