The entity cache is not reset after publishing a pending revision [#2382331]

Problem/Motivation

When publishing a pending revision, the entity is loaded and cached via entity_load() and then the database is updated in _revisioning_publish_revision(). The entity cache is never reset resulting in future calls to entity_load() returning the previously published revision of the entity that was cached. This became a problem when I expected data in the newly published revision to be indexed by Search API, but because the entity cache is never cleared, Search API loads the previously published revision and indexes that.

Proposed resolution

After updating the database, we should re-load the node resetting the entity cache.

Remaining tasks

Review the patch
Commit

Comment	File	Size	Author
#6	revisioning-n2382331-6.patch	888 bytes	DamienMcKenna
#6	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 CI error PHP 7.1 & MySQL 5.5, D7 Build Successful
#1	revisioning-publish-reset-cache-2382331-1.patch	935 bytes	jantoine
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jantoine CreditAttribution: jantoine commented 26 November 2014 at 07:44

Assigned:	jantoine	» Unassigned
Issue summary:	View changes
Status:	Active	» Needs review

File	Size
revisioning-publish-reset-cache-2382331-1.patch	935 bytes

The attached patch reloads the node directly after updating the database.

Comment #2

RdeBoer

Melbourne

CreditAttribution: RdeBoer commented 26 November 2014 at 08:58

Thanks for the patch Jon.
Makes sense.
Rik

Comment #3

vtkachenko CreditAttribution: vtkachenko commented 9 September 2015 at 13:33

Call of next code will lead to clearing All node cache.

node_load($node_revision->nid, NULL, TRUE);

https://api.drupal.org/api/drupal/includes!common.inc/function/entity_lo...

SEE:
$reset: Whether to reset the internal cache for the requested entity type.

So, it will clear cache not for specified entity but for all entities of this type.

Comment #4

Leeteq CreditAttribution: Leeteq commented 29 February 2016 at 17:16

Priority:

Normal

» Major

Comment #5

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 10 March 2016 at 16:15

Status:

Needs review

» Needs work

Using the $reset option on nodes doesn't make a huge deal with core, but when you use the EntityCache module it clears the cache for every entity of that type, i.e. it'll clear the entire node cache.