Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I think the default weights for the processors are currently not correct.
First should be all processors that remove items, then those that add fields, then those that work on individual characters (ignore case/characters, transliteration), then HTML Filter, Tokenizer, Stopwords et al.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2565663-5.patch | 7.73 KB | lhangea |
| |||
| #2 | 2565663-2.patch | 6.15 KB | lhangea |
| |||
Comments
Comment #2
lhangea CreditAttribution: lhangea commentedComment #3
drunken monkeyThanks a lot for your work on this, looks quite good!
However, three things:
1) More an aesthetic issue, but still: Normally, the custom is to go into the negative with the weights, so I'd rather give the ones that remove items something like -50, then -30 for those that add fields, -20 for the character based ones and then start with something like -10 for the others (leaving enough room in between for other processors). Sorry, should have mentioned that right away.
2) The order of the last three processors is actually important, it should always be: HTML Filter, Tokenizer, Stopwords. So these should have different weights.
3) Same for the "Aggregated fields" processor, though it's not that important: if it comes after all the other processors that add fields, it can actually use those fields, too, for aggregation.
Would you like to make those changes yourself? Otherwise, maybe I'll just make them, or we can wait whether someone else wants to pick this up.
In any case, thanks again for your help!
Comment #4
lhangea CreditAttribution: lhangea commentedI addressed your feedback. If there is anything else that you think should be fixed let me know.
For the 1st point I knew that the 'convention' in Drupal is to use negative weights but I don't really see the point so that's why I used positive weights. I think positive weights make more sense that negative weights because getting to 0 and needing to pass to positive weights is not really nice.
Comment #5
lhangea CreditAttribution: lhangea commentedComment #6
drunken monkeyExcellent, looks perfect now!
Committed.
Thanks again for your work!