Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
Plugins
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
9 Sep 2015 at 13:19 UTC
Updated:
13 Oct 2015 at 15:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
lhangea commentedComment #3
drunken monkeyThanks a lot for your work on this, looks quite good!
However, three things:
1) More an aesthetic issue, but still: Normally, the custom is to go into the negative with the weights, so I'd rather give the ones that remove items something like -50, then -30 for those that add fields, -20 for the character based ones and then start with something like -10 for the others (leaving enough room in between for other processors). Sorry, should have mentioned that right away.
2) The order of the last three processors is actually important, it should always be: HTML Filter, Tokenizer, Stopwords. So these should have different weights.
3) Same for the "Aggregated fields" processor, though it's not that important: if it comes after all the other processors that add fields, it can actually use those fields, too, for aggregation.
Would you like to make those changes yourself? Otherwise, maybe I'll just make them, or we can wait whether someone else wants to pick this up.
In any case, thanks again for your help!
Comment #4
lhangea commentedI addressed your feedback. If there is anything else that you think should be fixed let me know.
For the 1st point I knew that the 'convention' in Drupal is to use negative weights but I don't really see the point so that's why I used positive weights. I think positive weights make more sense that negative weights because getting to 0 and needing to pass to positive weights is not really nice.
Comment #5
lhangea commentedComment #6
drunken monkeyExcellent, looks perfect now!
Committed.
Thanks again for your work!