Problem/Motivation

UserStorage injects the 'password' service but since password fields are handled by PasswordItem, it is no longer used.

Proposed resolution

Remove dependency.

Remaining tasks

All

User interface changes

None

API changes

Change to constructor of UserStorage.

Data model changes

None

CommentFileSizeAuthor
#2 user-password-2565279.1.patch1.99 KBlarowlan

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new user-password-2565279.1.patch1.99 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Entity Field API

Status: Needs review » Needs work

The last submitted patch, 2: user-password-2565279.1.patch, failed testing.

Status: Needs work » Needs review

larowlan queued 2: user-password-2565279.1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: user-password-2565279.1.patch, failed testing.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

This third requeue didnt segfault, which leads me to believe that this may or may not be a drupalci issue. Lack of segfaults on qa.drupal.org/local may just indicate good luck

Trying again to see if I can get a core dump to see where the issue lies.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

Somebody else ran into a core dump over on: https://www.drupal.org/node/2546618#comment-10309439, so its not specific to this patch.

Status: Needs work » Needs review

keopx queued 2: user-password-2565279.1.patch for re-testing.

quietone’s picture

quietone commented
Version: 8.0.x-dev » 8.1.x-dev

clifen pointed out on IRC that this is not a bug fix, so it should be on 8.1.x.

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

Tests pass and didn't find any instantiations of this class.

Thanks to cilefen for support and guidance, during core mentoring hours.

  • catch committed d5a8623 on 8.1.x 
    Issue #2565279 by larowlan: UserStorage injects the password service,...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks! Nice that this removes the method overrides entirely.

RavindraSingh’s picture

RavindraSingh commented
Issue tags: -Novice

Removing 'novice' tag

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.