I think this is just a question of adding it to the config_export array in the Flagging entity annotation.

CommentFileSizeAuthor
#8 flag-2564529-8-weight-add-config-export-array.patch331 bytesrashid_786
#2 2564529-2.flag_.flag-weight-save.patch331 bytesjoachim

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 2564529-2.flag_.flag-weight-save.patch331 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2564529-2.flag_.flag-weight-save.patch, failed testing.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented

I think wrong core version.

joachim’s picture

joachim commented
Version: 7.x-3.x-dev » 8.x-4.x-dev

Haha. Thanks!

Status: Needs work » Needs review

joachim queued 2: 2564529-2.flag_.flag-weight-save.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: 2564529-2.flag_.flag-weight-save.patch, failed testing.

rashid_786’s picture

rashid_786 commented
Status: Needs work » Needs review
StatusFileSize
new flag-2564529-8-weight-add-config-export-array.patch331 bytes

Status: Needs review » Needs work

The last submitted patch, 8: flag-2564529-8-weight-add-config-export-array.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented

Fails are not related.
See #2565501: Tests are not working because Dynamic page cache was committed in core.

Status: Needs work » Needs review

joachim queued 8: flag-2564529-8-weight-add-config-export-array.patch for re-testing.

joachim’s picture

joachim commented

Did either of you try it out? What should happen is without the patch, the saved flag doesn't have a 'weight' property (in the config table). With the patch, it does. (The weight is always 0 because there's no UI yet, but that comes later...)

socketwench’s picture

socketwench commented
Status: Needs review » Needs work

So something in this patch is causing the test to stall. Looks like it happened to testbot, but also can confirm the behavior locally. It doesn't last more than a minute or two locally, but that may be why Testbot cancels out and never returns results.

Once the tests do complete, the weight is persisted to configuration.

Status: Needs work » Needs review

joachim queued 8: flag-2564529-8-weight-add-config-export-array.patch for re-testing.

socketwench’s picture

socketwench commented

15 hours later and still stuck. :-/

joachim’s picture

joachim commented

Well it passed again here, so I'm pretty sure it's a problem with your system somehow.

socketwench’s picture

socketwench commented
Status: Needs review » Reviewed & tested by the community

Yeah, it was my system. I was asking too much of it at the time and it stalled.

  • rashid_786 authored 9e685dc on 8.x-4.x 
    Issue #2564529 by joachim, rashid_786: Fixed flag weight is not saved.
socketwench’s picture

socketwench commented
Status: Reviewed & tested by the community » Fixed

And fixed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.