This needs testing in 6.x as well.

Steps to reproduce:

- Add a bunch of fields to a node type in D7.
- Add a piece of content in D7.
- In D8, run the migration (I used the UI in the latest version of Migrate Upgrade).
- The content gets migrated, but nothing but title and body come over.
- Be sad. :(

CommentFileSizeAuthor
#8 interdiff-2563819-7.txt2.72 KBphenaproxima
#7 2563819-7.patch8.55 KBphenaproxima
#7 2563819-7-FAIL.patch6.6 KBphenaproxima
#2 2563819-2-FAIL.patch2.39 KBphenaproxima
Screen Shot 2015-09-05 at 2.34.22 PM.png53.42 KBwebchick
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webchick created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
2563819-2-FAIL.patch2.39 KB

Fail patch proving the issue. It's real!

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Title: Non-body fields do not migrate » [D7] Field display settings do not migrate

On further investigation, I have discovered that what's actually broken here isn't the field definitions or values, but the display settings. They're not migrating correctly, so it only looks like fields are broken. Which is itself a critical brokenness, but still :)

Renaming the issue.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Active » Needs review

Sending to testbot so we can see it BURN.

Status: Needs review » Needs work

The last submitted patch, 2: 2563819-2-FAIL.patch, failed testing.

The last submitted patch, 2: 2563819-2-FAIL.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
FileSize
2563819-7-FAIL.patch6.6 KB
2563819-7.patch8.55 KB

I screwed up with git a bit, but hopefully these patches will do the trick.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
interdiff-2563819-7.txt2.72 KB

Forgot the interdiff.

The last submitted patch, 7: 2563819-7-FAIL.patch, failed testing.

The last submitted patch, 7: 2563819-7-FAIL.patch, failed testing.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Needs review » Reviewed & tested by the community

Code looks good, and my node fields show up on a D7 migration.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

This patch exposed a gnarly problem in #2410875: Migration for Drupal 7 Taxonomy vocabularies and terms so we should get this in.

Patch overall looks fine, although:

diff --git a/core/modules/field/migration_templates/d7_field_instance_widget_settings.yml b/core/modules/field/migration_templates/d7_field_instance_widget_settings.yml
index e75285d..3463ae9 100755
--- a/core/modules/field/migration_templates/d7_field_instance_widget_settings.yml
+++ b/core/modules/field/migration_templates/d7_field_instance_widget_settings.yml
@@ -15,12 +15,12 @@ process:
       plugin: migration
       migration: d7_field
       source:
-        - entity_type
         - field_name
+        - entity_type
     -
       plugin: extract
       index:
-        - 1
+        - 0
     -
       plugin: skip_on_empty
       method: row

Wow, that is some midnight dark black frigging magic. :\ I've literally no idea how someone who hadn't helped write this system would ever have figured that fix out. :( Thank you.

Committed and pushed to 8.0.x. YEAH!

  • webchick committed 10ea52e on 8.0.x 
    Issue #2563819 by phenaproxima, mikeryan: [D7] Field display settings do...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented

Sadly, this introduces a new SQLite fail, and thus a critical: #2566723: New test fail on PHP 5.5 & SQLite 3.8.

Any hopes of a quick fix?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.