I got a copy of the current Drupal 8.0.x and noticed that the admin menu toggle icon is misaligned but when it's toggled to the sidebar mode it seems fine.

This is a screenshot of the issue showing the probable cause which is a CSS rule in the toolbar.icons.theme.css file:

.toolbar .toolbar-bar .toolbar-icon:before {
  min-height: 3em;
}

Admin menu misaligned toggle icon
This is a screenshot of a quick fix using firebug which removes the style:
Admin menu misaligned toggle icon fix

I have only checked this issue on Linux's Firefox and Chrome browser.

CommentFileSizeAuthor
#5 2563807Result.png112.56 KBshwetaneelsharma
#2 core-fix-admin-menu-misaligned-toggle-icon-2563807-d8.patch569 bytesleolandotan
d8-admin-menu-toggle-misaligned-fix.png132.68 KBleolandotan
d8-admin-menu-toggle-misaligned.png130.56 KBleolandotan

Comments

leolando.tan created an issue. See original summary.

leolandotan’s picture

leolandotan commented
Status: Active » Needs review
StatusFileSize
new core-fix-admin-menu-misaligned-toggle-icon-2563807-d8.patch569 bytes

I went ahead and created a patch.

emma.maria’s picture

emma.maria
she/her
commented
Component: Bartik theme » toolbar.module

As the issue problem and code in the patch is for the the Toolbar module, this is not a Bartik issue. Assigning to toolbar.module.

leolandotan’s picture

leolandotan commented

Oh! I didn't notice that. My apologies.

shwetaneelsharma’s picture

shwetaneelsharma commented
StatusFileSize
new 2563807Result.png112.56 KB

Tested core-fix-admin-menu-misaligned-toggle-icon-2563807-d8.patch on Firefox Ubuntu 14.04
Attaching screenshot. The toggle icon is not fixed even after applying the patch. Therefore, the patch fails.

shwetaneelsharma’s picture

shwetaneelsharma commented
Status: Needs review » Needs work
leolandotan’s picture

leolandotan commented

Just wanted to clarify, after applying the patch did you clear the caches and if yes, the issue is only on Firefox?

Thanks!

tr’s picture

tr commented
Status: Needs work » Closed (duplicate)

I just noticed this bug too.

This bug was introduced by commit 184d4b42 from issue #2173527: The Menu-Toolbar area should be refactored so that Tray items are nested in the same container as their associated parent Toolbar item., and there's already an open issue for the problem, see #2546196: Toolbar's orientation-toggling arrows broken by #2173527.

@leolando.tan: You should post your proposed patch in that previous issue. But it looks like your patch just reverts commit d82a0ffb from issue #2267037: Toolbar tab icons without title are not aligned. That commit has been in place for more than a year and was added to fix the specific problem raised in that issue. Have you checked to make sure you haven't re-introduced the bug that was fixed by that previous commit?