Remove usage and function of test_page_test_page()

I found only one instance of test_page_test_page() which is in TestPageTestController. So I think, it is better if do both usage removal and function removal in one go. Also as test_page_test module only contains this function, so is it good to remove that file as well ?

Thoughts ?

In the mean time, here is patch for usage removal.

Hi @joshi.rohit100

I saw that you removed the call to "test_page_test_page()" function on the "TestPageTestController" file, but the function still on the .module file. I think that you should remove it from there.

Regards,

@naxolozano - Yes, I have only removed the usage (as per SI). To remove the function itself, IS needs update (see #2).
If it is fine to remove usage and function itself here in one go, please update SI, then we will do that here. Otherwise, I think #3 is what we have (as per current IS).

@joshi.rohit100 - Yes, I agree with your comment (#2, sorry, I didn't see before). I am going to rename the issue in order to cover both changes (Remove usage and function).

Patch with removed file

Patch with removed file and small fixes :)

1. One mention left in comment.
git grep test_page_test_page
core/modules/system/tests/modules/test_page_test/src/Controller/TestPageTestController.php: * @todo Remove test_page_test_page().

2.

+++ b/core/modules/system/tests/modules/test_page_test/src/Controller/TestPageTestController.php
@@ -16,7 +16,16 @@ class TestPageTestController {
+    $attached['drupalSettings']['test-setting'] = 'azAZ09();.,\\\/-_{}';
...
+      '#attached' => [
+        'drupalSettings' => [
+          'test-setting' => 'azAZ09();.,\\\/-_{}',
+        ]
+      ],

Remove $attached or use it to set '#attached'.

Thanks! Looks great!
+1 to rtbc

Looks fine for me!
+1 to RTBC

+1, just a nitpick ;)

+++ b/core/modules/system/tests/modules/test_page_test/src/Controller/TestPageTestController.php
@@ -13,10 +13,18 @@
+          'test-setting' => 'azAZ09();.,\\\/-_{}',
+        ]

needs comma after ]

Fixed patch

Upload interdiffs as well.

Less code and this only involves tests - nice. Committed 795d9f9 and pushed to 8.0.x. Thanks!