Per vincic on bitbucket:

Solves crash when you try to add a Solr server in search api.

CommentFileSizeAuthor
#14 metatag-n2563667-14.patch411 bytesMichelle
#8 metatag-n2563667-8.patch382 bytesDamienMcKenna
#2 metatag-n2563667-2.patch750 bytesDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Active » Needs review
FileSize
metatag-n2563667-2.patch750 bytes

The changes provided by vincic.

afi13’s picture

afi13 CreditAttribution: afi13 commented
Status: Needs review » Reviewed & tested by the community
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Committed.

  • DamienMcKenna committed 97797a1 on 8.x-1.x 
    Issue #2563667 by vicnic: MetatagManager should only be used for objects...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed
Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle at Mediacurrent commented
Status: Fixed » Needs work

This addition breaks the module unless you add use Drupal\Core\Entity\ContentEntityInterface; to the top of metatag.module. I'll do a patch when I don't have other changes in progress.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2563667-8.patch382 bytes

Thanks for pointing that out, Michelle. Is this sufficient?

Status: Needs review » Needs work

The last submitted patch, 8: metatag-n2563667-8.patch, failed testing.

The last submitted patch, 8: metatag-n2563667-8.patch, failed testing.

The last submitted patch, 8: metatag-n2563667-8.patch, failed testing.

The last submitted patch, 8: metatag-n2563667-8.patch, failed testing.

The last submitted patch, 8: metatag-n2563667-8.patch, failed testing.

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2563667-14.patch411 bytes

Works fine. I made one small change, though. The comment at the top that it's used by hook_help() wasn't relevant anymore now that there are other "use" statements there so I removed it.

Status: Needs review » Needs work

The last submitted patch, 14: metatag-n2563667-14.patch, failed testing.

The last submitted patch, 14: metatag-n2563667-14.patch, failed testing.

The last submitted patch, 14: metatag-n2563667-14.patch, failed testing.

The last submitted patch, 14: metatag-n2563667-14.patch, failed testing.

The last submitted patch, 14: metatag-n2563667-14.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

I've disabled the drupalci tests because they were failing for an unrelated error: #2581469: Metatag tests all failing with "Undefined variable: classes"

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.