Per vincic on bitbucket:

Solves crash when you try to add a Solr server in search api.

CommentFileSizeAuthor
#14 metatag-n2563667-14.patch411 bytesmichelle
#8 metatag-n2563667-8.patch382 bytesdamienmckenna
#2 metatag-n2563667-2.patch750 bytesdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2563667-2.patch750 bytes

The changes provided by vincic.

afi13’s picture

afi13 commented
Status: Needs review » Reviewed & tested by the community
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Committed.

  • DamienMcKenna committed 97797a1 on 8.x-1.x 
    Issue #2563667 by vicnic: MetatagManager should only be used for objects...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed
michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Fixed » Needs work

This addition breaks the module unless you add use Drupal\Core\Entity\ContentEntityInterface; to the top of metatag.module. I'll do a patch when I don't have other changes in progress.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2563667-8.patch382 bytes

Thanks for pointing that out, Michelle. Is this sufficient?

Status: Needs review » Needs work

The last submitted patch, 8: metatag-n2563667-8.patch, failed testing.

The last submitted patch, 8: metatag-n2563667-8.patch, failed testing.

The last submitted patch, 8: metatag-n2563667-8.patch, failed testing.

The last submitted patch, 8: metatag-n2563667-8.patch, failed testing.

The last submitted patch, 8: metatag-n2563667-8.patch, failed testing.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2563667-14.patch411 bytes

Works fine. I made one small change, though. The comment at the top that it's used by hook_help() wasn't relevant anymore now that there are other "use" statements there so I removed it.

Status: Needs review » Needs work

The last submitted patch, 14: metatag-n2563667-14.patch, failed testing.

The last submitted patch, 14: metatag-n2563667-14.patch, failed testing.

The last submitted patch, 14: metatag-n2563667-14.patch, failed testing.

The last submitted patch, 14: metatag-n2563667-14.patch, failed testing.

The last submitted patch, 14: metatag-n2563667-14.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I've disabled the drupalci tests because they were failing for an unrelated error: #2581469: Metatag tests all failing with "Undefined variable: classes"

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.