Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

Component: Dublin Core » Other tags
jlbellido’s picture

Issue tags: +DevDaysMilan

I'm going to work today on this issue during the Drupal Developers Days at Milan

jlbellido’s picture

Status: Active » Needs work
StatusFileSize
new47.92 KB

Here is a first patch with wich includes a first approach for migrating the metatag_mobile submodule to D8.

After some hours migrating by hand the old metatags types to the new metatag plugin system, I hacked locally the generate:tag command for generate automatically the plugins based on the implementation of D7. Because of this some classnames are not so accurate, but at least most of the work is automated and we'll only have to edit some stuffs.

During the migration process I had some doubts:

  1. Secure parameter: How can I identify this parameter in the old implementation of a metatag?
  2. Some of the metatags at the D7 version have something like: '#theme' => 'a custom theme here',, for example:
    $info['tags']['x-ua-compatible'] = array(
        'label' => t('X-UA-Compatible'),
        'description' => t('Indicates to IE which rendering engine should be used for the current page.'),
        'weight' => ++$weight,
        'element' => array(
          '#theme' => 'metatag_http_equiv',
        ),
      ) + $tag_info_defaults;
    

    How should be this implemented at the new plugin system?

  3. Some of the metatags at the D7 version have something like: 'header' => FALSE, How should be this implemented in the new plugin type?

NOTE: Big thanks to @penyaskito for giving me the idea of trying to automate the migration of the plugin implementations. Much funnier than doing it by hand.

damienmckenna’s picture

Not putting this into beta10.

damienmckenna’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: add_all_of_the_mobile-2563635-10.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new3.67 KB

WIP, this is a placeholder for the module, need to add the actual tags.

Status: Needs review » Needs work

The last submitted patch, 14: metatag-n2563635-14.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
Parent issue: » #2829190: Plan for Metatag 8.x-1.0-beta12
StatusFileSize
new1.68 KB
new3.18 KB

Fix the tests.

damienmckenna’s picture

StatusFileSize
new0 bytes

Combining #10 and #16.

Status: Needs review » Needs work

The last submitted patch, 17: metatag-n2563635-17.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new61.82 KB

Doh. *This* is the patch.

Status: Needs review » Needs work

The last submitted patch, 19: metatag-n2563635-19.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new60.58 KB

Major improvements, almost finished.

Status: Needs review » Needs work

The last submitted patch, 21: metatag-n2563635-21.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new65.13 KB
new10.28 KB

All of the tests pass locally.

I've added metatag_mobile_page_attachments_alter() to remove the three possible duplicate tags, the ios-app meta tag was renamed, and the verbose() override function was added.

  • DamienMcKenna committed 3edd6be on 8.x-1.x
    Issue #2563635 by jlbellido, DamienMcKenna: Ported all of the mobile...

  • DamienMcKenna committed 5d5c3bf on 8.x-1.x
    Issue #2563635 by jlbellido, DamienMcKenna: Ported all of the mobile...
damienmckenna’s picture

Status: Needs review » Fixed

Committed! Thanks all!

jlbellido’s picture

Thanks @DamienMckenna for your awesome work one more time!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.