Closed (fixed)
Project:
Metatag
Version:
8.x-1.x-dev
Component:
Other tags
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Sep 2015 at 10:36 UTC
Updated:
18 Jan 2017 at 10:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
damienmckennaComment #3
damienmckennaComment #4
damienmckennaComment #5
damienmckennaComment #6
damienmckennaComment #7
damienmckennaComment #8
damienmckennaComment #9
jlbellidoI'm going to work today on this issue during the Drupal Developers Days at Milan
Comment #10
jlbellidoHere is a first patch with wich includes a first approach for migrating the metatag_mobile submodule to D8.
After some hours migrating by hand the old metatags types to the new metatag plugin system, I hacked locally the generate:tag command for generate automatically the plugins based on the implementation of D7. Because of this some classnames are not so accurate, but at least most of the work is automated and we'll only have to edit some stuffs.
During the migration process I had some doubts:
'#theme' => 'a custom theme here',, for example:How should be this implemented at the new plugin system?
'header' => FALSE,How should be this implemented in the new plugin type?NOTE: Big thanks to @penyaskito for giving me the idea of trying to automate the migration of the plugin implementations. Much funnier than doing it by hand.
Comment #11
damienmckennaNot putting this into beta10.
Comment #12
damienmckennaComment #14
damienmckennaWIP, this is a placeholder for the module, need to add the actual tags.
Comment #16
damienmckennaFix the tests.
Comment #17
damienmckennaCombining #10 and #16.
Comment #19
damienmckennaDoh. *This* is the patch.
Comment #21
damienmckennaMajor improvements, almost finished.
Comment #23
damienmckennaAll of the tests pass locally.
I've added metatag_mobile_page_attachments_alter() to remove the three possible duplicate tags, the ios-app meta tag was renamed, and the verbose() override function was added.
Comment #26
damienmckennaCommitted! Thanks all!
Comment #27
jlbellidoThanks @DamienMckenna for your awesome work one more time!