Add all of the Favicon meta tags from the D7 branch to the 8.x-1.x branch. May need to split out the meta tags into submodules after all.

CommentFileSizeAuthor
#35 2563633-35.interdiff.txt10.19 KBziomizar
#35 2563633-35.patch10.94 KBziomizar
#33 metatag-2563633-33.patch1.33 KBziomizar
#29 metatag-n2563633-29.patch33.62 KBDamienMcKenna
#29 metatag-n2563633-29.interdiff.txt454 bytesDamienMcKenna
#27 metatag-n2563633-27.patch34.06 KBDamienMcKenna
#26 2563633-24-45.interdiff.txt8.44 KBruloweb
#26 2563633-25.patch34.3 KBruloweb
#24 2563633-19-24.interdiff.txt20.89 KBziomizar
#24 2563633-24.patch34.33 KBziomizar
#22 2563633-20.interdiff.txt6.47 KBziomizar
#22 2563633-20.patch33.24 KBziomizar
#19 2563633-19.interdiff.txt5.24 KBziomizar
#19 2563633-19.patch28.31 KBziomizar
#19 2563633-19--test-only.patch2.66 KBziomizar
#15 metatag-n2563633-15.patch23.04 KBziomizar
#12 metatag-n2563633-12.interdiff.txt1.24 KBDamienMcKenna
#12 metatag-n2563633-12.patch3.63 KBDamienMcKenna
#10 metatag-n2563633-10.patch3.62 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Component: Dublin Core » Other tags
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Parent issue: #2563607: Plan for Metatag 8.x-1.0-beta4 release » #2655294: Plan for Metatag 8.x-1.0-beta5 release
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Parent issue: #2655294: Plan for Metatag 8.x-1.0-beta5 release » #2684497: Plan for Metatag 8.x-1.0-beta6 release
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Parent issue: #2684497: Plan for Metatag 8.x-1.0-beta6 release » #2699057: Plan for Metatag 8.x-1.0-beta7 release
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Parent issue: #2699057: Plan for Metatag 8.x-1.0-beta7 release » #2699381: Plan for Metatag 8.x-1.0-beta8 release
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Parent issue: #2699381: Plan for Metatag 8.x-1.0-beta8 release » #2725269: Plan for Metatag 8.x-1.0-beta9 release
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Parent issue: #2725269: Plan for Metatag 8.x-1.0-beta9 release » #2741339: Plan for Metatag 8.x-1.0-beta10 release
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: #2741339: Plan for Metatag 8.x-1.0-beta10 release »

Not putting this into beta10.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
metatag-n2563633-10.patch3.62 KB

WIP, adds a placeholder module, doesn't add the tags yet.

Status: Needs review » Needs work

The last submitted patch, 10: metatag-n2563633-10.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
Parent issue: » #2829190: Plan for Metatag 8.x-1.0-beta12
FileSize
metatag-n2563633-12.patch3.63 KB
metatag-n2563633-12.interdiff.txt1.24 KB

This should fix the current changes.

  • DamienMcKenna committed 506686a on 8.x-1.x 
    Issue #2563633 by DamienMcKenna: Added a placeholder to store the...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

Committed. Now to port the actual meta tags themselves.

ziomizar’s picture

ziomizar CreditAttribution: ziomizar as a volunteer and at East Atlantic Engineering commented
Status: Needs work » Needs review
FileSize
metatag-n2563633-15.patch23.04 KB

I've created all the favicons plugins from 7.x.

All the favicons print the right tag on frontend except for mask-icon that need works to handle the color and the url.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

@ziomizar: Thanks for doing that!

One other thing that needs to be done is to add the meta tags to Drupal\metatag_favicons\Tests\MetatagFaviconsTagsTest::$tags so that the tests will check them.

ziomizar’s picture

ziomizar CreditAttribution: ziomizar as a volunteer and at East Atlantic Engineering commented

Hi @DamienMcKenna,

Thanks, running test as you suggested i saw that also schema is missing i'm fixing that as well.
I guess that test needs to extend also testTagsInputOutput() method in MetatagTagsTestBase because on line 222 there is an assert that return error if more than one tag with the same name is found.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

The testTagsInputOutput() method should work out of the box, there should only be one of each meta tag present. If something else up being problematic, comment out that meta tag in the tests and leave a @todo item so I can look into it. Thanks!

ziomizar’s picture

ziomizar CreditAttribution: ziomizar as a volunteer and at East Atlantic Engineering commented
Status: Needs work » Needs review
FileSize
2563633-19--test-only.patch2.66 KB
2563633-19.patch28.31 KB
2563633-19.interdiff.txt5.24 KB

- add schema for all favicons.
- add $tags for all favincs tests and fixed few issues with naming.

The last submitted patch, 19: 2563633-19--test-only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 19: 2563633-19.patch, failed testing.

ziomizar’s picture

ziomizar CreditAttribution: ziomizar as a volunteer and at East Atlantic Engineering commented
Status: Needs work » Needs review
FileSize
2563633-20.patch33.24 KB
2563633-20.interdiff.txt6.47 KB

Implements {meta_tag_name}_test_output_xpath()

Status: Needs review » Needs work

The last submitted patch, 22: 2563633-20.patch, failed testing.

ziomizar’s picture

ziomizar CreditAttribution: ziomizar as a volunteer and at East Atlantic Engineering commented
Status: Needs work » Needs review
FileSize
2563633-24.patch34.33 KB
2563633-19-24.interdiff.txt20.89 KB

Fixed metatag ids and tests.
Remove default shortcut icon tag if it is defined from metatag module.

ziomizar’s picture

ziomizar CreditAttribution: ziomizar as a volunteer and at East Atlantic Engineering commented

@DamienMcKenna have you some suggestions in how to proceed to implements the mask-icon?

We need an extra field "color" in the same tag configurable from backend.

ruloweb’s picture

ruloweb CreditAttribution: ruloweb at Anexus commented
Category: Task » Feature request
FileSize
2563633-25.patch34.3 KB
2563633-24-45.interdiff.txt8.44 KB

Hi all, this patch only remove a few blank spaces at the end of a few lines.

Thanks for the feature-request, it worked ok for me.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n2563633-27.patch34.06 KB

Some minor refactoring, I don't like the verbose class files. (no interdiff because it's mostly renaming class files)

Status: Needs review » Needs work

The last submitted patch, 27: metatag-n2563633-27.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2563633-29.interdiff.txt454 bytes
metatag-n2563633-29.patch33.62 KB

Doh, too much search/replace.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Related issues: +#2563615: Plan for Metatag 8.x-1.1 release

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed. Thanks everyone!

ziomizar’s picture

ziomizar CreditAttribution: ziomizar as a volunteer and at East Atlantic Engineering commented
FileSize
metatag-2563633-33.patch1.33 KB

Hi Damien,

Thanks! I found just 2 typo in the code.

I'm not sure if was better open a new issue just for that.

ziomizar’s picture

ziomizar CreditAttribution: ziomizar as a volunteer and at East Atlantic Engineering commented
Status: Fixed » Needs review
ziomizar’s picture

ziomizar CreditAttribution: ziomizar as a volunteer and at East Atlantic Engineering commented
FileSize
2563633-35.patch10.94 KB
2563633-35.interdiff.txt10.19 KB

Also the "use" statement is wrong in all the Icons that are using LinkSizesBase

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Thanks for spotting those! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
CreditAttribution: pingwin4eg as a volunteer commented

That is great work, of course! But some meta missing additional attributes. Like color in mask-icon or type in icon.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

There's an existing issue for the mask-icon color, feel free to open one for the icon type.