Add all of the Favicon meta tags from the D7 branch to the 8.x-1.x branch. May need to split out the meta tags into submodules after all.
| Comment | File | Size | Author |
|---|---|---|---|
| #35 | 2563633-35.interdiff.txt | 10.19 KB | ziomizar |
| #35 | 2563633-35.patch | 10.94 KB | ziomizar |
| #33 | metatag-2563633-33.patch | 1.33 KB | ziomizar |
| #29 | metatag-n2563633-29.patch | 33.62 KB | damienmckenna |
| #29 | metatag-n2563633-29.interdiff.txt | 454 bytes | damienmckenna |
Comments
Comment #2
damienmckennaComment #3
damienmckennaComment #4
damienmckennaComment #5
damienmckennaComment #6
damienmckennaComment #7
damienmckennaComment #8
damienmckennaComment #9
damienmckennaNot putting this into beta10.
Comment #10
damienmckennaWIP, adds a placeholder module, doesn't add the tags yet.
Comment #12
damienmckennaThis should fix the current changes.
Comment #14
damienmckennaCommitted. Now to port the actual meta tags themselves.
Comment #15
ziomizar commentedI've created all the favicons plugins from 7.x.
All the favicons print the right tag on frontend except for mask-icon that need works to handle the color and the url.
Comment #16
damienmckenna@ziomizar: Thanks for doing that!
One other thing that needs to be done is to add the meta tags to Drupal\metatag_favicons\Tests\MetatagFaviconsTagsTest::$tags so that the tests will check them.
Comment #17
ziomizar commentedHi @DamienMcKenna,
Thanks, running test as you suggested i saw that also schema is missing i'm fixing that as well.
I guess that test needs to extend also testTagsInputOutput() method in MetatagTagsTestBase because on line 222 there is an assert that return error if more than one tag with the same name is found.
Comment #18
damienmckennaThe testTagsInputOutput() method should work out of the box, there should only be one of each meta tag present. If something else up being problematic, comment out that meta tag in the tests and leave a @todo item so I can look into it. Thanks!
Comment #19
ziomizar commented- add schema for all favicons.
- add $tags for all favincs tests and fixed few issues with naming.
Comment #22
ziomizar commentedImplements {meta_tag_name}_test_output_xpath()
Comment #24
ziomizar commentedFixed metatag ids and tests.
Remove default shortcut icon tag if it is defined from metatag module.
Comment #25
ziomizar commented@DamienMcKenna have you some suggestions in how to proceed to implements the mask-icon?
We need an extra field "color" in the same tag configurable from backend.
Comment #26
ruloweb commentedHi all, this patch only remove a few blank spaces at the end of a few lines.
Thanks for the feature-request, it worked ok for me.
Comment #27
damienmckennaSome minor refactoring, I don't like the verbose class files. (no interdiff because it's mostly renaming class files)
Comment #29
damienmckennaDoh, too much search/replace.
Comment #30
damienmckennaComment #32
damienmckennaCommitted. Thanks everyone!
Comment #33
ziomizar commentedHi Damien,
Thanks! I found just 2 typo in the code.
I'm not sure if was better open a new issue just for that.
Comment #34
ziomizar commentedComment #35
ziomizar commentedAlso the "use" statement is wrong in all the Icons that are using LinkSizesBase
Comment #37
damienmckennaThanks for spotting those! Committed.
Comment #39
pingwin4egThat is great work, of course! But some meta missing additional attributes. Like color in mask-icon or type in icon.
Comment #40
damienmckennaThere's an existing issue for the mask-icon color, feel free to open one for the icon type.