Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

Component: Dublin Core » Other tags
DamienMcKenna’s picture

couturier’s picture

This sounds like an excellent idea to me. I've just built a new Drupal 8 site and need to validate it, so I'm looking for solutions currently. This will become more important as Drupal 8 use becomes more widespread.

Jim.M’s picture

@DamienMcKenna - We wrote the Site Verification D8 module. I'm happy to continue on the path and write the validation tags for MetaTag 8.x if you'd like?

Jim

DamienMcKenna’s picture

@Jim.M: I'd be grateful for any help you could provide. Please check the other D8 issues (e.g. #2563623: Add the main OpenGraph meta tags to 8.x-1.x) for how I'd like this structured.

Jim.M’s picture

Assigned: Unassigned » Jim.M
DamienMcKenna’s picture

Moving this to beta6 so that beta5 can be released more quickly.

DamienMcKenna’s picture

DamienMcKenna’s picture

Jim.M’s picture

I've created a bunch of the most popular verification tags classes under "Site Validation" fieldset. Here's the patch file. I think we can add other tags by an on-demand basis. Now I'm going to add an ability to create verification files for some of the services on-the-fly (I personally prefer this method to meta tags).

I think we can add placeholders to the metatags to show data format (like UA-XXXXXXXX-X for GA for instance). What do you think about it?

matsbla’s picture

I tested #11 and seems like working great, thanks!

matsbla’s picture

I guess it should be

not:

matsbla’s picture

I guess it should be
<meta name="google-site-verification"
not:
<meta property="google-site-verification"

Jim.M’s picture

matsbla, you're right, my final code review "cleaned it up". I rerolled the patch, here it is.

DamienMcKenna’s picture

Status: Active » Needs review

Oh that's awesome, thank you!

As a reminder, please remember to set the issue status to "needs review", that way it'll trigger the testbots, and let others know there's a file to review.

DamienMcKenna’s picture

I've renamed the submodule to metatag_verification, and updated the descriptions to match what's used in the D7 module.

Status: Needs review » Needs work

The last submitted patch, 17: metatag-n2563629-17.patch, failed testing.

The last submitted patch, 17: metatag-n2563629-17.patch, failed testing.

DamienMcKenna’s picture

I renamed the classes so they don't have the "Sv" prefix anymore, and the tests should work now.

  • DamienMcKenna committed c4b4adf on 8.x-1.x authored by Jim.M
    Issue #2563629 by Jim.M, DamienMcKenna: Added site verification tags.
    
DamienMcKenna’s picture

Status: Needs review » Fixed

Committed. Thanks Jim.M!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

DamienMcKenna’s picture

Assigned: Jim.M » Unassigned