Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Add all of the Site Validation meta tags from the D7 branch to the 8.x-1.x branch. May need to split out the meta tags into submodules after all.
Comment | File | Size | Author |
---|---|---|---|
#20 | metatag-n2563629-20.patch | 12.21 KB | DamienMcKenna |
Comments
Comment #2
DamienMcKennaComment #3
DamienMcKennaComment #4
couturier CreditAttribution: couturier as a volunteer commentedThis sounds like an excellent idea to me. I've just built a new Drupal 8 site and need to validate it, so I'm looking for solutions currently. This will become more important as Drupal 8 use becomes more widespread.
Comment #5
Jim.M CreditAttribution: Jim.M commented@DamienMcKenna - We wrote the Site Verification D8 module. I'm happy to continue on the path and write the validation tags for MetaTag 8.x if you'd like?
Jim
Comment #6
DamienMcKenna@Jim.M: I'd be grateful for any help you could provide. Please check the other D8 issues (e.g. #2563623: Add the main OpenGraph meta tags to 8.x-1.x) for how I'd like this structured.
Comment #7
Jim.M CreditAttribution: Jim.M as a volunteer commentedComment #8
DamienMcKennaMoving this to beta6 so that beta5 can be released more quickly.
Comment #9
DamienMcKennaKicking this one down the road to beta7.
Comment #10
DamienMcKennaComment #11
Jim.M CreditAttribution: Jim.M as a volunteer commentedI've created a bunch of the most popular verification tags classes under "Site Validation" fieldset. Here's the patch file. I think we can add other tags by an on-demand basis. Now I'm going to add an ability to create verification files for some of the services on-the-fly (I personally prefer this method to meta tags).
I think we can add placeholders to the metatags to show data format (like UA-XXXXXXXX-X for GA for instance). What do you think about it?
Comment #12
matsbla CreditAttribution: matsbla commentedI tested #11 and seems like working great, thanks!
Comment #13
matsbla CreditAttribution: matsbla commentedI guess it should be
not:
Comment #14
matsbla CreditAttribution: matsbla commentedI guess it should be
<meta name="google-site-verification"
not:
<meta property="google-site-verification"
Comment #15
Jim.M CreditAttribution: Jim.M as a volunteer commentedmatsbla, you're right, my final code review "cleaned it up". I rerolled the patch, here it is.
Comment #16
DamienMcKennaOh that's awesome, thank you!
As a reminder, please remember to set the issue status to "needs review", that way it'll trigger the testbots, and let others know there's a file to review.
Comment #17
DamienMcKennaI've renamed the submodule to metatag_verification, and updated the descriptions to match what's used in the D7 module.
Comment #20
DamienMcKennaI renamed the classes so they don't have the "Sv" prefix anymore, and the tests should work now.
Comment #22
DamienMcKennaCommitted. Thanks Jim.M!
Comment #24
DamienMcKenna