Add all of the Site Validation meta tags from the D7 branch to the 8.x-1.x branch. May need to split out the meta tags into submodules after all.
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | metatag-n2563629-20.patch | 12.21 KB | damienmckenna |
Add all of the Site Validation meta tags from the D7 branch to the 8.x-1.x branch. May need to split out the meta tags into submodules after all.
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | metatag-n2563629-20.patch | 12.21 KB | damienmckenna |
Comments
Comment #2
damienmckennaComment #3
damienmckennaComment #4
couturier commentedThis sounds like an excellent idea to me. I've just built a new Drupal 8 site and need to validate it, so I'm looking for solutions currently. This will become more important as Drupal 8 use becomes more widespread.
Comment #5
jim.m commented@DamienMcKenna - We wrote the Site Verification D8 module. I'm happy to continue on the path and write the validation tags for MetaTag 8.x if you'd like?
Jim
Comment #6
damienmckenna@Jim.M: I'd be grateful for any help you could provide. Please check the other D8 issues (e.g. #2563623: Add the main OpenGraph meta tags to 8.x-1.x) for how I'd like this structured.
Comment #7
jim.m commentedComment #8
damienmckennaMoving this to beta6 so that beta5 can be released more quickly.
Comment #9
damienmckennaKicking this one down the road to beta7.
Comment #10
damienmckennaComment #11
jim.m commentedI've created a bunch of the most popular verification tags classes under "Site Validation" fieldset. Here's the patch file. I think we can add other tags by an on-demand basis. Now I'm going to add an ability to create verification files for some of the services on-the-fly (I personally prefer this method to meta tags).
I think we can add placeholders to the metatags to show data format (like UA-XXXXXXXX-X for GA for instance). What do you think about it?
Comment #12
matsbla commentedI tested #11 and seems like working great, thanks!
Comment #13
matsbla commentedI guess it should be
not:
Comment #14
matsbla commentedI guess it should be
<meta name="google-site-verification"not:
<meta property="google-site-verification"Comment #15
jim.m commentedmatsbla, you're right, my final code review "cleaned it up". I rerolled the patch, here it is.
Comment #16
damienmckennaOh that's awesome, thank you!
As a reminder, please remember to set the issue status to "needs review", that way it'll trigger the testbots, and let others know there's a file to review.
Comment #17
damienmckennaI've renamed the submodule to metatag_verification, and updated the descriptions to match what's used in the D7 module.
Comment #20
damienmckennaI renamed the classes so they don't have the "Sv" prefix anymore, and the tests should work now.
Comment #22
damienmckennaCommitted. Thanks Jim.M!
Comment #24
damienmckenna