Problem/Motivation

This blocks a ctools issue to allow ajax calls to be using the ajax_deliver. #1710710: ajax_render should not be used; ajax_deliver should be used instead.

Proposed resolution

Commit patch:)

Remaining tasks

User interface changes

API changes

Data model changes

Follow-up to #1710710: ajax_render should not be used; ajax_deliver should be used instead.

CommentFileSizeAuthor
#7 ajax_render_should_not-2563431-3.patch477 byteslauriii
#3 ajax_render_should_not-2563431-3.patch477 bytesjoelpittet
#2 views-list-page-do-not-test.patch477 bytesjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new views-list-page-do-not-test.patch477 bytes

This patch was from @effulgentsia in #1710710-20: ajax_render should not be used; ajax_deliver should be used instead.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new ajax_render_should_not-2563431-3.patch477 bytes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Reviewed & tested by the community
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

We've recently switched our testing from the old qa.drupal.org to DrupalCI. Because of a bug in the new system, #2623840: Views (D7) patches not being tested, older patches must be re-uploaded. On re-uploading the patch, please set the status to "Needs Review" so that the test bot will add it to its queue.

If all tests pass, change the Status back to "Reviewed & tested by the community". We'll most likely commit the patch immediately without having to go through another round of peer review.

We apologize for the trouble, and appreciate your patience.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs review
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new ajax_render_should_not-2563431-3.patch477 bytes
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Doesn't RTBC status still get checked too by Testbot even with the new CI stuff? Anyways, thanks for reposting @lauriii, back to RTBC.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Yeah, looks like it. I wasn't sure before.

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

.

  • dawehner committed 2ff6729 on 7.x-3.x authored by joelpittet 
    Issue #2563431 by joelpittet, lauriii: ajax_render should not be used;...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.