Problem/Motivation

Since we are dropping the set() method from SafeMarkup due to the issue #2554889: Remove SafeMarkup::set() from the codebase the method must be removed from diff as well.

Proposed resolution

Remove\Replace the calls to the method and create a patch, review.

Remaining tasks

create patch, Review and commit.

User interface changes

Data model changes

Original report by [juanse254]

CommentFileSizeAuthor
#5 SafeMarkup_set_remove-2563017-5.patch2.21 KBjuanse254
#5 interdiff-2563017-2-5.txt734 bytesjuanse254
#2 SafeMarkup_set_remove-2563017-2.patch2.1 KBjuanse254

Comments

juanse254 created an issue. See original summary.

juanse254’s picture

juanse254 commented
Status: Active » Needs review
StatusFileSize
new SafeMarkup_set_remove-2563017-2.patch2.1 KB

After this gets committed #2549907: Fix schema langcode error and this #2557979: SafeMarkup::placeholder() has been removed, SafeMarkup class has changed, update needed we will be able to commit this(actual issue), and then the tests will be green again and everything working. Currently the module is not working correctly.

Status: Needs review » Needs work

The last submitted patch, 2: SafeMarkup_set_remove-2563017-2.patch, failed testing.

LKS90’s picture

LKS90 commented 
+++ b/src/EntityComparisonBase.php
@@ -83,7 +82,7 @@ class EntityComparisonBase extends ControllerBase {
+    $this->nonBreakingSpace = t('&nbsp');

I don't think non breaking spaces are translatable :P.

juanse254’s picture

juanse254 commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2563017-2-5.txt734 bytes
new SafeMarkup_set_remove-2563017-5.patch2.21 KB

Something like this :).

Status: Needs review » Needs work

The last submitted patch, 5: SafeMarkup_set_remove-2563017-5.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Wouldn't it be easier to just merge this into #2557979: SafeMarkup::placeholder() has been removed, SafeMarkup class has changed, update needed? That's not yet committed, also related to SafeMarkup and this patch is quite small.

Status: Needs work » Needs review

juanse254 queued 5: SafeMarkup_set_remove-2563017-5.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: SafeMarkup_set_remove-2563017-5.patch, failed testing.

hampercm’s picture

hampercm commented
Parent issue: » #2557979: SafeMarkup::placeholder() has been removed, SafeMarkup class has changed, update needed

Verified @juanse254 has incorporated this patch into the linked parent issue #2557979: SafeMarkup::placeholder() has been removed, SafeMarkup class has changed, update needed. Can this issue be closed?

lhangea’s picture

lhangea commented
Status: Needs work » Closed (duplicate)

Ok, I close this one then.