SafeMarkup::placeholder() has been removed, SafeMarkup class has changed, update needed

Tested locally and patch solved the problem but now with latest core changes tests are still failing.

#507488: Convert page elements (local tasks, actions) into blocks We must include blocks in tests and also there was a problem with SafeMarkup::set() but it will be removed soon #2554889: Remove SafeMarkup::set() from the codebase so we should extend this patch after it gets committed.

For now I am uploading a patch with fixes for those changes instead of creating another issue(fixes are related in some way) and I hope a maintainer will look over this and #2549907: Fix schema langcode error soon.

hampercm and giancarlosotelo thanks for your work. These days I can look over some of the issues from the queue and update the 8.0.x branch accordingly.

+++ b/src/Controller/NodeRevisionController.php
@@ -110,7 +110,9 @@ class NodeRevisionController extends EntityComparisonBase {
+                $field_diff_column['data']['#markup'] = SafeMarkup::set($field_diff_column['data']['#markup']);

I think we should avoid using SafeMarkup::set()

The rest looks good to me, tested locally and is passing.

EDIT:

+++ b/src/Controller/NodeRevisionController.php
@@ -110,7 +110,9 @@ class NodeRevisionController extends EntityComparisonBase {
         foreach ($field_diff_rows as &$field_diff_row) {
           foreach ($field_diff_row as &$field_diff_column) {
             if (is_array($field_diff_column)) {
-              $field_diff_column['data'] = SafeMarkup::set($field_diff_column['data']);
+              if (isset($field_diff_column['data']['#markup'])) {
+                $field_diff_column['data']['#markup'] = SafeMarkup::set($field_diff_column['data']['#markup']);
+              }
             }
             else {

I think we can drop this whole thing.

This will merge this two issues #2563017: SafeMarkup::set() removed from core with this one and should solve both.

I know the test is postponed because of the previous fail we had in HEAD so I just went ahead and committed this change. Tests pass locally the module seems to work OK.

Back to fixed, the patch is already applied.