Problem/Motivation

ParagraphsAdministrationTest is failing because #507488: Convert page elements (local tasks, actions) into blocks was committed and actions are missing and cannot be clicked.

Proposed resolution

Load the module block and add tasks and actions blocks.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 fix_test-12.patch2.93 KBgiancarlosotelo
#12 interdiff-7-12.txt750 bytesgiancarlosotelo
#7 fix_test-7.patch3 KBgiancarlosotelo
#2 fix_test-2.patch1.2 KBgiancarlosotelo

Comments

giancarlosotelo created an issue. See original summary.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Active » Needs review
StatusFileSize
new fix_test-2.patch1.2 KB

This should works and a small fix to the test.

LKS90’s picture

LKS90 commented
Status: Needs review » Reviewed & tested by the community

Good to go.

LKS90’s picture

LKS90 commented

Double Post, pls ignore.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: fix_test-2.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Looks like the blocks are missing in some other tests too.

giancarlosotelo’s picture

giancarlosotelo commented
StatusFileSize
new fix_test-7.patch3 KB

Added blocks to others tests.

A test is failing, it seems a paragraph is not translated well. I will investigate.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: fix_test-7.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented

Fails because of #2540556: Translated paragraphs is not displayed in the correct translation, is not related.

juanse254’s picture

juanse254 commented
Status: Needs work » Needs review

Everything works as supposed, just wondering about

+++ b/src/Tests/ParagraphsAdministrationTest.php
@@ -202,7 +204,7 @@ class ParagraphsAdministrationTest extends WebTestBase {
-    $this->drupalPostForm(NULL, NULL, t('Save settings'));
+    $this->drupalPostForm(NULL, NULL, t('Save content type'));

is this right?

the rest is fine.

giancarlosotelo’s picture

giancarlosotelo commented
StatusFileSize
new interdiff-7-12.txt750 bytes
new fix_test-12.patch2.93 KB

I checked and it wasn't right, I was editing the article instead of the paragraph.
Now is fine I changed the number in the edit link. Thanks.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks pretty fine to me. Let's have the bot happy again...

jeroen.b’s picture

jeroen.b commented
Status: Reviewed & tested by the community » Fixed

Thanks, pushed to dev!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.