Problem/Motivation

The d7_user role plugin retrieves roles for each user as an array of role names, keyed by role ID. Because D6/7 roles are identified only by their numeric ID, This makes it impossible for later migrations to look up the role(s) assigned to a user, and can cause fatal errors.

Proposed Resolution

The plugin should retrieve roles the same way the d6_user plugin does -- as an array of numeric IDs.

Remaining Tasks

Patch, review, commit. Post-haste!

API/UI Changes

None.

CommentFileSizeAuthor
#2 2562081-2.patch1.59 KBphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 2562081-2.patch1.59 KB

Initial patch, with adjusted tests.

Status: Needs review » Needs work

The last submitted patch, 2: 2562081-2.patch, failed testing.

Status: Needs work » Needs review

phenaproxima queued 2: 2562081-2.patch for re-testing.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Reviewed & tested by the community

lgtm - lest someone else question why there isn't a new test to identify the problem, I can see that the existing test was malformed to expect the wrong structure as it was implemented.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Oops. :P

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 3d9ba61 on 8.0.x 
    Issue #2562081 by phenaproxima: d7_user source plugin handles user roles...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.