Don't know which of the recent commits breaks the Payment Sensor but we are getting this error and is not because of dependencies:

Call to undefined method Drupal\monitoring\Plugin\monitoring\SensorPlugin\PaymentTurnoverSensorPlugin::getEntityTypeId()

We should set the entity type id from the settings.

CommentFileSizeAuthor
#5 add_payment_test.patch2.45 KBgiancarlosotelo
#5 remove_payment_test.patch2.46 KBgiancarlosotelo
#4 2561801-4.patch2.54 KBgiancarlosotelo
#4 interdiff-2-4.txt1.86 KBgiancarlosotelo
#2 2561801-2.patch785 bytesgiancarlosotelo

Comments

giancarlosotelo created an issue. See original summary.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Active » Needs review
StatusFileSize
new 2561801-2.patch785 bytes

This should works.

Should we set the entity type as payment in the default settings? or just let the default entity type as node ? ( extends from ContentEntityAggregatorSensorPlugin)

With this patch the only test that should fail is MonitoringCaptcha, search_api is already fixed (at least locally everything was green :) )

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Yes, while fixing this, let's make sure to update this sensor to follow the watchdog.. non-configurable table and aggregate field with defaults.

Note that this will *not* pass on testbot as payment requires composer_manager now to function. We will need to disable or remove the payment test for now. We can do it in a similar way as collect for d8status and have a separate patch that adds the test back there. @mbovan knows how to do this.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-4.txt1.86 KB
new 2561801-4.patch2.54 KB

Payment doesn't have a table to set, extends from ContentEntity so a Entity type should be selected but I am creating a property to have this non configurable so in case that a Payment sensor is created the entity type should be payment by default and no configurable.

Also Payment entity has no timestamp fields so I am removing that(non configurable). I don't know which other fields should be by default.

For now I will upload the patch and then the testbot stuff.

giancarlosotelo’s picture

giancarlosotelo commented
StatusFileSize
new remove_payment_test.patch2.46 KB
new add_payment_test.patch2.45 KB

Ok uploading an add and remove patch for the Payment test.

Here is the PR for d8status https://github.com/Berdir/d8modulestatus/pull/38

  • Berdir committed 975709b on 8.x-1.x authored by giancarlosotelo 
    Issue #2561801 by giancarlosotelo: Payment sensor is broken because some...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

I committed the fixes and the remove patch.

I suggest you open a new issue, titled "Add payment test again when testbot supports composer dependencies"

giancarlosotelo’s picture

giancarlosotelo commented

Issue created #2564195: Add payment test again when testbot supports composer dependencies

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 2: 2561801-2.patch, failed testing.

The last submitted patch, 4: 2561801-4.patch, failed testing.

The last submitted patch, 5: remove_payment_test.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 5: add_payment_test.patch, failed testing.

juanse254’s picture

juanse254 commented
Status: Needs work » Closed (fixed)

The last submitted patch, 2: 2561801-2.patch, failed testing.

The last submitted patch, 4: 2561801-4.patch, failed testing.

The last submitted patch, 5: remove_payment_test.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 5: add_payment_test.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Closed (fixed)