Problem/Motivation

This will help #2429617: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!).

#2443457: Views block displayed when no results returned introduced test coverage, which unfortunately just chose the default frontpage (which is the user login form in the testing install profile) as the route for its testing. But, that route/controller has certain cacheability metadata associated with it that makes it less clear what is being tested.

Proposed resolution

Make what is being tested more clear by using a route that has only the most basic cacheability metadata (because it has a hardcoded render array).

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

Status: Active » Needs review
StatusFileSize
new4.29 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2561757-2.patch, failed testing.

wim leers’s picture

Status: Needs work » Needs review
StatusFileSize
new4.29 KB

Rebased.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Whatever is normal these days

wim leers’s picture

Priority: Normal » Minor

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2561757-4.patch, failed testing.

borisson_’s picture

Status: Needs work » Needs review
StatusFileSize
new7.33 KB

Reroll

wim leers’s picture

Status: Needs review » Needs work

Your PHPUnit XML file got mixed up in there.

borisson_’s picture

Status: Needs work » Needs review
StatusFileSize
new4.28 KB
wim leers’s picture

Status: Needs review » Reviewed & tested by the community

Identical changes to #4, so back to RTBC per #5.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 31a65da and pushed to 8.0.x. Thanks!

  • alexpott committed 31a65da on 8.0.x
    Issue #2561757 by Wim Leers, borisson_: Follow-up for #2443457: improve...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.