Part of #2545972: Remove all code usages SafeMarkup::checkPlain() and rely more on Twig autoescaping

Problem/Motivation

SafeMarkup::checkPlain() is unnecessary.

Proposed resolution

EntityListBuilder does not need to SafeMarkup::checkPlain() the entity label.

Remaining tasks

Do it
Review
Commit

User interface changes

None

API changes

EntityListBuilder::getLabel() is deprecated.

Data model changes

None

CommentFileSizeAuthor
#5 2-5-interdiff.txt942 bytesalexpott
#5 2560851.5.patch16.8 KBalexpott
#2 2560851.2.patch16.49 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2560851.2.patch16.49 KB
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Cool stuff! (Comment as requested, review coming later if needed)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Adding @Xano to credit list because of work on #2560641: Remove all usages SafeMarkup::checkPlain() from render arrays

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2560851.5.patch16.8 KB
new 2-5-interdiff.txt942 bytes

Fixing docs...

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Reviewed & tested by the community

If this passes its RTBC I think

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Added a small CR https://www.drupal.org/node/2561005

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 42c9be9 on 8.0.x 
    Issue #2560851 by alexpott, Xano: Deprecate EntityListBuilder::getLabel...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.