Part of #2545972: Remove all code usages SafeMarkup::checkPlain() and rely more on Twig autoescaping

Problem/Motivation

SafeMarkup::checkPlain() is unnecessary.

Proposed resolution

EntityListBuilder does not need to SafeMarkup::checkPlain() the entity label.

Remaining tasks

Do it
Review
Commit

User interface changes

None

API changes

EntityListBuilder::getLabel() is deprecated.

Data model changes

None

CommentFileSizeAuthor
#5 2-5-interdiff.txt942 bytesalexpott
#5 2560851.5.patch16.8 KBalexpott
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 109,984 pass(es). View
#2 2560851.2.patch16.49 KBalexpott
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 109,011 pass(es). View
Join #DrupalCares to support the DA through COVID-19. Drupal Association Give today

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
FileSize
16.49 KB
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 109,011 pass(es). View
Xano’s picture

Cool stuff! (Comment as requested, review coming later if needed)

alexpott’s picture

alexpott’s picture

FileSize
16.8 KB
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 109,984 pass(es). View
942 bytes

Fixing docs...

lauriii’s picture

Status: Needs review » Reviewed & tested by the community

If this passes its RTBC I think

alexpott’s picture

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 42c9be9 on 8.0.x
    Issue #2560851 by alexpott, Xano: Deprecate EntityListBuilder::getLabel...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.