Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of #2545972: Remove all code usages SafeMarkup::checkPlain() and rely more on Twig autoescaping
Problem/Motivation
SafeMarkup::checkPlain()
is unnecessary.
Proposed resolution
EntityListBuilder does not need to SafeMarkup::checkPlain() the entity label.
Remaining tasks
Do it
Review
Commit
User interface changes
None
API changes
EntityListBuilder::getLabel() is deprecated.
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#5 | 2-5-interdiff.txt | 942 bytes | alexpott |
#5 | 2560851.5.patch | 16.8 KB | alexpott |
#2 | 2560851.2.patch | 16.49 KB | alexpott |
Comments
Comment #2
alexpottComment #3
XanoCool stuff! (Comment as requested, review coming later if needed)
Comment #4
alexpottAdding @Xano to credit list because of work on #2560641: Remove all usages SafeMarkup::checkPlain() from render arrays
Comment #5
alexpottFixing docs...
Comment #6
lauriiiIf this passes its RTBC I think
Comment #7
alexpottAdded a small CR https://www.drupal.org/node/2561005
Comment #8
catchCommitted/pushed to 8.0.x, thanks!