The destination plugin needs to be invalidated when using ->set()

CommentFileSizeAuthor
#9 interdiff-2560659-4-9.txt1.18 KBphenaproxima
#9 2560659-9.patch2.08 KBphenaproxima
#4 2560659-4.patch2.02 KBbenjy
#3 2560659-3.patch2.05 KBbenjy
invalidate-destination.patch587 bytesbenjy

Comments

benjy created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Makes sense.

benjy’s picture

benjy commented
StatusFileSize
new 2560659-3.patch2.05 KB

Now with tests.

benjy’s picture

benjy commented
StatusFileSize
new 2560659-4.patch2.02 KB

Try again, CI didn't like that patch.

benjy’s picture

benjy commented
Status: Reviewed & tested by the community » Needs review

The last submitted patch, 3: 2560659-3.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

An RTBC patch is a happy patch!

neclimdul’s picture

neclimdul
He/Him
commented
Status: Reviewed & tested by the community » Needs work

I feel bad about this. 

+++ b/core/modules/migrate/src/Tests/MigrationTest.php
@@ -0,0 +1,44 @@
+/**
+ * Tests the migration entity.
+ *
+ * @group migrate
+ */
+class MigrationTest extends KernelTestBase {
...
+   * @covers ::set()

I feel terribly guilty doing this but we're adding a @covers without @coversDefaultClass. It doesn't really matter ATM because this is using the simpletest KTB(it enables modules so it has to ATM). Even so we should get it write so it gets picked up later when this is hopefully switched over to KTBTNG.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2560659-9.patch2.08 KB
new interdiff-2560659-4-9.txt1.18 KB

Fixed.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 634dfce on 8.0.x 
    Issue #2560659 by benjy, phenaproxima, neclimdul: Invalidate the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.