Problem/Motivation

Since some recent commit, the MonitoringUITest testSensorListLimit is broken...
https://qa.drupal.org/pifr/test/742098

Fatal error: Call to undefined method Drupal\monitoring\Plugin\monitoring\SensorPlugin\ContentEntityAggregatorSensorPlugin::id() in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/monitoring/src/Plugin/monitoring/SensorPlugin/ContentEntityAggregatorSensorPlugin.php on line 292
FATAL Drupal\monitoring\Tests\MonitoringUITest: test runner returned a non-zero error code (255).

Confusion: People claim this was passing... ;-)

Proposed resolution

Investigate and fix that.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 fix_test_fail-2560609-3.patch527 bytesgiancarlosotelo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

miro_dietiker created an issue. See original summary.

miro_dietiker’s picture

Issue summary: View changes
giancarlosotelo’s picture

Status: Active » Needs review
FileSize
527 bytes

I found the problem.
We are setting the default configuration(entity type => 'node') for the Content Entity Aggregator just when the ajax is called ( one of the recent commits) so for the UI works well always but trying to create a Content Entity sensor by coding doesn't works because the entity type is missing so I am adding the entity type in the test and now the UI test is green again :)

LKS90’s picture

Status: Needs review » Reviewed & tested by the community

Yep, the tests needed an update after the recent commits. I wish we had automated testing again, but what can we do... :D.

miro_dietiker’s picture

Status: Reviewed & tested by the community » Fixed

Fixed. Yeah, it was me... My local system currently doesn't like to run tests and i was too lazy to wait... :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 3: fix_test_fail-2560609-3.patch, failed testing.

juanse254’s picture

Status: Needs work » Closed (fixed)

Status: Closed (fixed) » Needs work

The last submitted patch, 3: fix_test_fail-2560609-3.patch, failed testing.

giancarlosotelo’s picture

Status: Needs work » Closed (fixed)