As PIFT/PIFR is phased out, issues will need to be set to "needs work" status if they fail DrupalCI test set to "Issues & on commit" for the branch (in addition to old QA bot test failure).

Comments

hestenet created an issue. See original summary.

drumm’s picture

Assigned: Unassigned » drumm
drumm’s picture

Issue summary: View changes

Clarifying that both DrupalCI & QA.Drupal.org will set issues to "needs work". This makes the implementation more straightforward, and lets QA.Drupal.org catch any straggling DrupalCI false positives.

Normally, this might look like

  1. Patch fails tests on DrupalCI, it is set to "needs work"
  2. Patch fails tests on QA.Drupal.org, it is already at "needs work", nothing happens

The downside is that there is more chance for humans cross-posting with the robot, during the short window where both testing can update the issue status.

drumm’s picture

Issue summary: View changes

This will consider tests set to "Issues & on commit" for the branch as set in the project's "Automated testing" settings.

  • drumm committed 13af642 on 7.x-3.x
    Issue #2560555: Issues should be set to "needs work" when patches fail...
drumm’s picture

Status: Active » Fixed
Issue tags: +needs drupal.org deployment

This is working well in my testing, and can be deployed later today.

drumm’s picture

Issue tags: -needs drupal.org deployment

This is now in production.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.