MigrateDestinationPluginManager declares the $themeHandler and $providers members, even though they aren't used at all.
On the other hand, __construct() gets the entityManager, but $entityManager is not defined on the class.
git blame couldn't tell me when this was introduced.

Let's clean it up.

CommentFileSizeAuthor
#2 2560423-1-migrate-wrong-class-members.patch1.91 KBbojanz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Active » Needs review
FileSize
2560423-1-migrate-wrong-class-members.patch1.91 KB

Removed the $themeManager and $providers members.
Added the $entityManager member.
Fixed the constructor documentation.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

I guess that was some bad copy and paste. Patch looks fine.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed eca67ab and pushed to 8.0.x. Thanks!

  • alexpott committed eca67ab on 8.0.x 
    Issue #2560423 by bojanz: MigrateDestinationPluginManager has wrong...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.