When viewing the full node, the comment icon appears when it shouldn't as it's accompanied without text. The way to fix it is to attach the icon to the comment link. 

 .comment_comments {
padding: 3px 0 5px 21px;
background: url(images/comment.jpg) no-repeat left center;
}

Right?? Or am I missing something obvious?

Comments

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented

Sorry that I have no idea about your problem:

When viewing the full node, the comment icon appears when it shouldn't as it's accompanied without text.

First of all, interactive_media don't have CSS tag .comment_comments. On the other hand, the comment links is already wrapped with this PHP (please check comment.tpl.php), which means if nothing appear in $links no div block will be shown:

    <div class="meta">
      <?php if ($links): ?><div class="commentslink"><?php print $links ?></div><?php endif; ?>
    </div>
Prodigy’s picture

Prodigy CreditAttribution: Prodigy commented

Misunderstanding.

It's probably everyones problem, but it's not a comment issue.

Using this theme, view a node that allows comments and go to the comment page and you will see what I mean.

Pay attention to the .meta .comment links section, the icon will show on the full node page.

Prodigy’s picture

Prodigy CreditAttribution: Prodigy commented

See the link above, look where it says "Roots Blog", the comment icon appears next to it.

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented
Component: Code » User interface
Assigned: Unassigned » hswong3i
Status: Active » Closed (works as designed)

Refer to comment.tpl.php (yes, this page is for D6; well, both D5/6 share the same idea), which means that $links is NOT only related to comment, but also other information. :

$links: Various operational links.

So yes, the CSS is called as .meta .commentslink and image is called as comments.png; No, this is not a bug but just a naming problem, which is a legacy naming style from K2. That icon just means for "here is some interesting stuff!" but not only target for comment.

Prodigy’s picture

Prodigy CreditAttribution: Prodigy commented

Right, I understand you could change the icon to whatever you wanted to display "interesting stuff", but I just thought I would chime in. My original suggestion on adding the comment icon as a background image to the .comment. comments add reply (can't remember off hand) does work though.

Anways, thanks very the fast reply and the theme is really looking great. I'll try to help you out in the support section as help is needed. Goodnight!

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented
Category: bug » feature
Status: Closed (works as designed) » Needs review

Well... Man, you win. You trigger my hidden motivation... I hope to do so for a long time ago...

You ask for fancy, so I give something more fancy: I add a lot of icons for meta data, and theme most core hook_link() functions. Please check my site (D5 and D6) for more idea. I am not sure if everyone like this fancy style; BTW, at least it looks great, too ;p

Already commit code to both 5.x-1.x-dev and 6.x-1.x-dev. If you are able to access CVS, check out latest code for the change; or else you may wait for drupal.org project publish system to renew the development snapshot package. Please feel free to comment for other idea :D

Prodigy’s picture

Prodigy CreditAttribution: Prodigy commented

Then you fixed it, good work. It looks a lot better, and now the "full node" page .comment links look a lot cleaner.

Off topic, but what was your motivation in giving the .meta a height of 20px, and and line-height of 20px in one of the newer updates?

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented

Ooops... This is a bit tricky (http://www.evolt.org/article/Ten_CSS_tricks_you_may_not_know/17/60369/):

8. Vertically aligning with CSS

Vertically aligning with tables was a doddle. To make cell content line up in the middle of a cell you would use vertical-align: middle. This doesn't really work with a CSS layout. Say you have a navigation menu item whose height is assigned 2em and you insert this vertical align command into the CSS rule. It basically won't make a difference and the text will be pushed to the top of the box.

Hmmm... not the desired effect. The solution? Specify the line height to be the same as the height of the box itself in the CSS. In this instance, the box is 2em high, so we would insert line-height: 2em into the CSS rule and the text now floats in the middle of the box - perfect!

This is not only useful for block title and primary link (take contented7 and internet_services as example), but also for meta data so we don't need to handle the margin/padding fancily :D

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented
Version: 5.x-1.x-dev » 6.x-1.5
Status: Needs review » Fixed

Layout is now sync update with contented7 and internet_service, too. If no border this issues should mark as fixed.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.