Everything in misc folder except ajax.js and tabledrag.js (because they have lots of errors themselves). 

✖ 102 problems (0 errors, 102 warnings)
CommentFileSizeAuthor
#13 jsdoc_misc-2559697-13.patch21.95 KBdimaro
#10 jsdoc_misc-2559697-10.patch21.94 KBthemusician
#8 jsdoc_misc-2559697-8.patch21.94 KBajits
#6 jsdoc_misc-2559697-6.patch21.94 KBeiriksm

Comments

nod_ created an issue. See original summary.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Related issues: +#2559695: JSDoc tabledrag.js, +#2559693: JSDoc ajax.js
Jarmihi’s picture

Jarmihi commented

I know how to use the old JavaDoc syntax, so I'll give this a shot. I'll read up on the differences right quick and get back with some work done.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Assigned: Unassigned » eiriksm

Working on this as a light start to the sprints :)

nod_’s picture

nod_
Primary language French
Location Lille
commented

eiriksm to the rescue!

There are a lot of things here, feel free to split things up if needed.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Active » Needs review
StatusFileSize
new jsdoc_misc-2559697-6.patch21.94 KB

OK, first take.

Status: Needs review » Needs work

The last submitted patch, 6: jsdoc_misc-2559697-6.patch, failed testing.

ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Assigned: eiriksm » Unassigned
Status: Needs work » Needs review
StatusFileSize
new jsdoc_misc-2559697-8.patch21.94 KB

Patch was not applicable. Rerolled.

themusician’s picture

themusician commented

Rerolling as it is not applying cleanly.

themusician’s picture

themusician commented
StatusFileSize
new jsdoc_misc-2559697-10.patch21.94 KB

I've rerolled the patch. Queued for testing.

davidbass’s picture

davidbass commented
Status: Needs review » Reviewed & tested by the community

Looking good; applied cleanly on the latest pull of 8.0.x.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: jsdoc_misc-2559697-10.patch, failed testing.

dimaro’s picture

dimaro commented
Status: Needs work » Needs review
StatusFileSize
new jsdoc_misc-2559697-13.patch21.95 KB

Patch was not applicable.
Rerolled.

Hope it works.

ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Status: Needs review » Reviewed & tested by the community
nod_’s picture

nod_
Primary language French
Location Lille
commented

From 215 eslint doc warning to 120. We could argue for months on the exact docs to write but this is a good first step. RTBC +1.

droplet’s picture

droplet commented

From 215 eslint doc warning to 120. We could argue for months on the exact docs to write but this is a good first step. RTBC +1.

So ture if there's no visible regressions, kick it in first.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks!

  • catch committed f33c6be on 8.1.x 
    Issue #2559697 by theMusician, eiriksm, AjitS, dimaro: JSDoc misc/

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.