Getting this error on PHP 5.6. It looks like the problem is in Views but it means the code in here needs to match Views. I've run into this same issue in other modules and know how to fix it.

Strict warning: Declaration of gmap_plugin_style_gmap::options_validate() should be compatible with views_plugin::options_validate($form, &$form_state) in views_include_handler() (line 98 of /sites/all/modules/contrib/views/includes/handlers.inc).

CommentFileSizeAuthor
#7 gmap_strict-warnings_2559557-7.patch928 bytesmichelle
#2 gmap-options_validate-2559557-2.patch627 bytesmichelle

Comments

Michelle created an issue. See original summary.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Issue summary: View changes
Status: Active » Needs review
Issue tags: +PHP 5.4
StatusFileSize
new gmap-options_validate-2559557-2.patch627 bytes

Here's the patch.

Status: Needs review » Needs work

The last submitted patch, 2: gmap-options_validate-2559557-2.patch, failed testing.

Status: Needs work » Needs review

Michelle queued 2: gmap-options_validate-2559557-2.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: gmap-options_validate-2559557-2.patch, failed testing.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Well, I haven't the foggiest idea why this patch is failing. It's the same change that was needed for other projects to make it compatible with Views in PHP 5.6. In Views, it is "function options_validate($form, &$form_state) { }" with no "&" on it so other modules that use that have to match.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
StatusFileSize
new gmap_strict-warnings_2559557-7.patch928 bytes

Updated the patch to account for another warning.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Title: Strict warning: Declaration of gmap_plugin_style_gmap::options_validate() should be compatible with views_plugin::options_validate » Strict warnings
Status: Needs work » Needs review

Forgot to set it needs review plus fixing title.