Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Follow-up to #2559445: Replace !placeholder with @placeholder in aggregator module
Problem/Motivation
In order to make #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests approachable, we need to break it up into smaller chunks. This issue address !placeholder in the SimpleTest module
See #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand for complete motivation on removal of !placeholder
Proposed resolution
Replace !placeholder with @placeholder in the SimpleTest module.
core/modules/simpletest/*
Remaining tasks
- Replace !placeholder with @placeholder. Refer to patch in #2506445-85: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests as that patch should have related update
- Ensure tests come back clean
- Manually test the update and post screen shot after patch, review source for any difference in escaping.
User interface changes
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | replace_placeholder-2559457-6.patch | 0 bytes | Sutharsan |
| |||
| #3 | replace_placeholder-2559457-3.patch | 3.6 KB | geertvd |
| #3 | interdiff-2559457-2-3.txt | 2.84 KB | geertvd |
| #2 | replace_placeholder-2559457-2.patch | 6.44 KB | joelpittet |
Comments
Comment #2
joelpittetComment #3
geertvd CreditAttribution: geertvd at XIO commentedRemoving replacements in hook_help since this is covered in #2560783: Replace !placeholder with :placeholder for URLs in hook_help() implementations
Comment #4
justAChris CreditAttribution: justAChris as a volunteer commentedPostponed on determining plan in parent #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand and then analyzing whether this individual issue still makes sense.
Comment #5
justAChris CreditAttribution: justAChris as a volunteer commentedClosing this, splitting by module was not the ideal approach to removing !placeholder. Marking as duplicate of #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand, since the chosen approach is / will be outlined there, please refer to it for any additional action.
Comment #6
Sutharsan CreditAttribution: Sutharsan as a volunteer commentedRerolling patch for easy migration into single patch at #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests.
Changing status for test bot. Do revert status after test.
Comment #8
Sutharsan CreditAttribution: Sutharsan as a volunteer commentedAll changes in #3 have already been committed in #256435: Cannot Create Block Views With Specific Taxonomy Vocabulary. Closing the issue.
Comment #9
justAChris CreditAttribution: justAChris as a volunteer commented"Fixed" indicates it was fixed in this issue, changing to closed (duplicate) since it was fixed elsewhere.
Comment #10
xjm