#2549013: Remove load plugins removed the load plugin concept from the migration system. That commit is triggering failures with the #2555183: Fix the filled update tests, they are broken patch - it looks like a number of migration tests continue to reference load plugins, those references need to be removed.

CommentFileSizeAuthor
#5 migration_tests-2559355-5.patch2.56 KBmikeryan

Comments

mikeryan created an issue. See original summary.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I am not sure removing test references would fix #2555183: Fix the filled update tests, they are broken, only its own tests fail (otherwise core head would fail of course). I would suspect something in the migrate runtime still puts them there. I do see these:

core/modules/migrate/src/Tests/MigrateEventsTest.php:      'load' => ['plugin' => 'null'],
core/modules/migrate/src/Tests/MigrateInterruptionTest.php:      'load' => ['plugin' => 'null'],
core/modules/migrate/src/Tests/MigrateStatusTest.php:      'load' => ['plugin' => 'null'],
catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +D8 upgrade path, +beta target
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Priority: Critical » Normal
Issue tags: -Quickfix, -D8 upgrade path, -beta target
Parent issue: #2555183: Fix the filled update tests, they are broken »
Related issues: +#2549013: Remove load plugins

Upon further discussion with Gabor, these vestiges of load plugins are not causing the problems with the update path. They should still go though, I'll roll a patch...

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Active » Needs review
StatusFileSize
new migration_tests-2559355-5.patch2.56 KB
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

The patch looks good though :)

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 7569493 on 8.0.x 
    Issue #2559355 by mikeryan: Migration tests reference defunct load...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.