Problem/Motivation

The list of sensor types in the filter is not displayed in alphabetical order and it is a bit confusing.

Proposed resolution

Order the list before displaying it.

Remaining tasks

User interface changes

None

API changes

Data model changes

CommentFileSizeAuthor
#5 2558617-5.patch441 bytesgiancarlosotelo
#2 2558617-2.patch441 bytesgiancarlosotelo

Comments

giancarlosotelo created an issue. See original summary.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Active » Needs review
StatusFileSize
new 2558617-2.patch441 bytes

Sensors types are added into the filter while sensors appear(order by category) that's why the type is not always in order.
Doing a sort by its keys should be enough.

juanse254’s picture

juanse254 commented
Status: Needs review » Needs work

hum test?

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Why sort by the key? The user only sees the label and thus it should be ordered by the label.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Needs review
StatusFileSize
new 2558617-5.patch441 bytes

Sorting by label now.
Discussed with @Berdir and test is not really necessary for this issue.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Fully agree. Thx!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 2: 2558617-2.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 5: 2558617-5.patch, failed testing.

juanse254’s picture

juanse254 commented
Status: Needs work » Closed (fixed)

The last submitted patch, 2: 2558617-2.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 5: 2558617-5.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Closed (fixed)