Modify the counting logic.

Yes. Since if you see the code(.module file), all the queries are written in hook_block_view. Hence this gets called only when block is rendered i guess. Even i was surprised by this.

Hi,

I tested the same and found the opposite.

Created a video.

Thanks

Lomas

Moving to 8.x-1.x so that it is debugged and fixed in D 8/9 release as well.

I didn't see any issues in views getting logged but the logic of counting a view and other statistics should be moved to an event subscriber.

Currently, the logic which is used to count the number of views is placed in the block code. It is causing 2 issues: Views not getting counted if block isn't placed and practically no caching for the counter block. Event subscribers would be a better way to execute the counting logic.

I have moved the logic to count views to an event subscriber, will keep this issue open till all the other improvement related issues are closed.

Closing this one for now as most of the coding practice improvement related issues have been fixed.