I had a real hard time finding this, because it's named something completely different here than it is on the discount add form. They should be the same.

CommentFileSizeAuthor
#4 2558151-4.discount_info.patch1.78 KBrszrama
#3 2558151-3.discount_info.patch1.61 KBrszrama

Comments

rszrama created an issue. See original summary.

rszrama’s picture

rszrama commented

Apparently this goes for all properties - they all need to be revised. The magic behavior of the Entity API is making this much harder to track down and fix than if it were simply declared in an array in this module, though I understand the drive to have this stuff automatically scaffolded out. The solution is to use the Entity API to rough out the array but then to customize the labels and descriptions with user friendly terms.

rszrama’s picture

rszrama commented
Status: Active » Needs review
StatusFileSize
new 2558151-3.discount_info.patch1.61 KB

Patch attached.

rszrama’s picture

rszrama commented
StatusFileSize
new 2558151-4.discount_info.patch1.78 KB

This patch also adds support for the sort_order column, assuming I can commit that patch.

Status: Needs review » Needs work

The last submitted patch, 4: 2558151-4.discount_info.patch, failed testing.

rszrama’s picture

rszrama commented

D'oh. Should've specified that one as not to be tested. Of course it would fail given sort_order doesn't exist.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

This looks very helpful in #3

Status: Needs work » Needs review

rszrama queued 4: 2558151-4.discount_info.patch for re-testing.

  • rszrama committed a7bfd51 on 7.x-1.x 
    Issue #2558151 by rszrama: improve the labels and descriptions of the...
rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Awesome, committed it along w/ the sort order fix.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.