Problem/Motivation

Description of Verbose Output Configuration in Add sensor form for Content Entity Aggregator doesn't change when the entity type is changed.

This could lead to an error if someone wants to add verbose fields from the description and then nothing is show.

Proposed resolution

Update the description every time that the entity type is changed.

Remaining tasks

Review patch, commit.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 verbose_description-2557145-5.patch2.16 KBgiancarlosotelo
#5 verbose_description-2557145-TESTONLY.patch1.36 KBgiancarlosotelo
#2 verbose_description-2557145-2.patch819 bytesgiancarlosotelo

Comments

giancarlosotelo created an issue. See original summary.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Active » Needs review
StatusFileSize
new verbose_description-2557145-2.patch819 bytes

Patch here.

Status: Needs review » Needs work

The last submitted patch, 2: verbose_description-2557145-2.patch, failed testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Yeah, looks good, but i think we also want to have test coverage.
Although there is no rela JS aware driver, there is an Ajax post command to do testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Needs review
StatusFileSize
new verbose_description-2557145-TESTONLY.patch1.36 KB
new verbose_description-2557145-5.patch2.16 KB

More UI tests and a testonly patch.

LKS90’s picture

LKS90 commented
Status: Needs review » Reviewed & tested by the community

Ran the test and tested it locally. Works as expected! :D

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Needed a reroll. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 5: verbose_description-2557145-TESTONLY.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 5: verbose_description-2557145-5.patch, failed testing.

juanse254’s picture

juanse254 commented
Status: Needs work » Closed (fixed)

The last submitted patch, 2: verbose_description-2557145-2.patch, failed testing.

The last submitted patch, 5: verbose_description-2557145-TESTONLY.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 5: verbose_description-2557145-5.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Closed (fixed)