Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Aug 2015 at 22:01 UTC
Updated:
15 Apr 2016 at 12:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
geertvd commented#2553533: KernelTestBaseTNG™ is not cleaning up after itself is in so this can be set to active
Comment #3
dawehnerI'm pretty sure you would run into #2553661: KernelTestBase fails to set up FileCache
Comment #4
dawehnerPlease keep in mind the following quote, see https://www.drupal.org/node/2489956
Comment #5
geertvd commentedThis was pretty straightforward.
I ported 2 existing tests as an example (
CommentUserNameTestandRenderCacheIntegrationTest), these are passing locally for me.I guess those ported tests should be removed from this patch before it get's committed as porting those existing tests should be done in another ticket.
I did have to apply #2553661: KernelTestBase fails to set up FileCache so this is still included in this patch.
Comment #6
geertvd commentedI need to fix that file block in the next patch.
Comment #8
geertvd commentedComment #9
dawehnerI'm curious whether we could move all that code from ViewKernelTestBase into a trait and then have a happy world in which we can share the code ...
Comment #10
geertvd commentedSomething like this then.
Comment #11
dawehnerOh that looks much much better!
I'm not entirely sure whether the trait should implement setup(), but for now this seems okay.
Comment #12
geertvd commentedYea, I thought about not adding the
setUp()method to the trait, but I thought the same could be said aboutsetUpFixtures.For now I think this is postponed until #2553661: KernelTestBase fails to set up FileCache is in.
Comment #13
geertvd commented#2553661: KernelTestBase fails to set up FileCache is in now so we can continue with this.
I ported
\Drupal\views\Tests\BasicTestto use the newViewKernelTestBaseto include some form of test coverage for this patch.Comment #15
dawehnerI really like the patch! I mean it enables a better future but I'm not sure whether this can land at this point.
Comment #16
heykarthikwithupatch no longer applies.
Comment #17
dawehnerWe no longer need this issue
Comment #19
dawehnerMeh
Comment #20
dbjpanda commentedWhile trying to reroll this patch for 8.2.x, i got to know that ViewKernelTestBase class has been removed in 8.2.x but still its there. I am a newbie. Can any one please help me to clear this confusion.
Comment #21
dawehner@dbjpanda Don't worry about this issue. Its fixed. Some flakyness on d.o. reopened the ticket though