I have just noticed something that is goes against the grain, when compare with other contrib modules.

Here is the quote from flag_bookmark.module

This module creates a default Flag and associated views WHEN enabled.

WHEN is my emphasis.

The convention seems to be that when a site maintainer/developer invokes a command like

drush en flag_bookmark

Then the implicit intent is to make sure all associated modules are enabled ... so everything work automatically.

I have listed this as a minor issue, because I can't conceive of having a D8 site without views.
.... maybe someone who turns unused module off for performance....

But it is going to catch that one in a thousand developer...

CommentFileSizeAuthor
#4 missingViews-4.patch854 bytessocketwench
missingViews-0.patch844 bytesmartin107

Comments

martin107 created an issue. See original summary.

socketwench’s picture

Status: Active » Reviewed & tested by the community

Looks good!

socketwench’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
socketwench’s picture

Status: Needs work » Needs review
StatusFileSize
new854 bytes

  • martin107 authored 7e51002 on
    Issue #2556739 by socketwench, martin107: Updated module dependencies to...
socketwench’s picture

Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ivnish’s picture

Issue tags: -Needs reroll