Problem/Motivation

After fixing #2554445: Tests broken due to core change safemarkup::XssFilter() the some links remained broken, therefore here we will change the leftovers.
To recreate request a translation and the download link for the result will be broken.

Proposed resolution

use @ instead of ! in the file translator and add tests for this.

Remaining tasks

Review and commit.

User interface changes

Data model changes

Original report by [username]

CommentFileSizeAuthor
#10 Fix_view-2556513-7-TEST-ONLY.patch3.07 KBjuanse254
#8 Fix_view-2556513-7.patch3.94 KBjuanse254
#7 Dropdownfix_2482137-10-TEST-ONLY.patch1.94 KBjuanse254
#4 Fix_view-2556513-2.patch894 bytesjuanse254
Fix_view-1.patch1.17 KBjuanse254

Comments

juanse254 created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, Fix_view-1.patch, failed testing.

juanse254’s picture

juanse254 commented
Issue summary: View changes
juanse254’s picture

juanse254 commented
Status: Needs work » Needs review
StatusFileSize
new Fix_view-2556513-2.patch894 bytes

Ups, wrong patch

Status: Needs review » Needs work

The last submitted patch, 4: Fix_view-2556513-2.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Component: User interface » Translator: File
Issue tags: +Needs tests

Title is confusing, has absolutely nothing do with sources but with the file translator. Also, we need tests for this.

juanse254’s picture

juanse254 commented
Status: Needs work » Needs review
StatusFileSize
new Dropdownfix_2482137-10-TEST-ONLY.patch1.94 KB

EDIT: do not review this, wrong patch.

juanse254’s picture

juanse254 commented
StatusFileSize
new Fix_view-2556513-7.patch3.94 KB

Test + fix. will update the summary.

The last submitted patch, 7: Dropdownfix_2482137-10-TEST-ONLY.patch, failed testing.

juanse254’s picture

juanse254 commented
StatusFileSize
new Fix_view-2556513-7-TEST-ONLY.patch3.07 KB

Ups wrong test :p

Status: Needs review » Needs work

The last submitted patch, 10: Fix_view-2556513-7-TEST-ONLY.patch, failed testing.

juanse254’s picture

juanse254 commented
Status: Needs work » Needs review
juanse254’s picture

juanse254 commented
Title: Fix View not showing link correctly » Broken download link for filetranslator generated file
Issue summary: View changes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed
Issue tags: -Needs tests

Thanks, committed.

  • Berdir committed 73953b6 on 8.x-1.x authored by juanse254 
    Issue #2556513 by juanse254: Fixed broken download link for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.