We do not need to assign a entity_manger each time we pass through the loop.

I do understand the line premature/micro optimization is the root of all evil.....

BUT while reviewing #2555365: Add views schema for flag_relationship

I spotted this .... I hope this is "QuickFix" as it that will take a 1/2 second to review and reorder....
far longer than it would take to prove through profiling :)

If we have 2 flags then this is not a concern, I am sure even with 1000 flags it will not be a problem, so for me I want to call this a distraction.

CommentFileSizeAuthor
#3 loop-2555483-3.patch720 bytesmartin107
loop-0.txt720 bytesmartin107

Comments

martin107 created an issue. See original summary.

joshtaylor’s picture

joshtaylor commented
Status: Needs review » Reviewed & tested by the community

Good spot.

martin107’s picture

martin107 commented
StatusFileSize
new loop-2555483-3.patch720 bytes

Thanks for the review.

.txt is not a good name for a patch file.... reupload the same file.

martin107--

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: loop-2555483-3.patch, failed testing.

joshtaylor’s picture

joshtaylor commented

Test failure is fixed in another issue..

martin107’s picture

martin107 commented
Status: Needs work » Postponed

Ok lets postpone until the critical is fixed.

#2555833: SafeMarkup::placeholder has been removed.

socketwench’s picture

socketwench commented

Should be ready to RTBC when #2555833: SafeMarkup::placeholder has been removed. is in.

joachim’s picture

joachim commented
Status: Postponed » Fixed

Well-spotted :)

Committed.

  • joachim committed 616b880 on 8.x-4.x authored by martin107 
    Issue #2555483 by martin107: Fixed repeated getting of service in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.