Problem/Motivation

The default Field API behavior is hiding empty fields, however this no longer happens once a field is formatted through this module.

Proposed resolution

Fix it

Remaining tasks

  • Write a patch
  • Reviews

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#7 expanding_formatter-2555025-7.txt888 bytesplach
#7 expanding_formatter-2555025-7.patch36.07 KBplach
#7 expanding_formatter-2555025-6.patch895 bytesplach
#5 expanding_formatter-2555025-5.patch893 bytesplach
#3 expanding_formatter-2555025-3.patch886 bytesplach
#2 expanding_formatter-2555025-2.patch36.07 KBplach

Comments

plach created an issue. See original summary.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review
StatusFileSize
new expanding_formatter-2555025-2.patch36.07 KB
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new expanding_formatter-2555025-3.patch886 bytes

Oops, something went wrong with new lines...

Status: Needs review » Needs work

The last submitted patch, 3: expanding_formatter-2555025-3.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review
StatusFileSize
new expanding_formatter-2555025-5.patch893 bytes

Let's try this...

Status: Needs review » Needs work

The last submitted patch, 5: expanding_formatter-2555025-5.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review
StatusFileSize
new expanding_formatter-2555025-6.patch895 bytes
new expanding_formatter-2555025-7.patch36.07 KB
new expanding_formatter-2555025-7.txt888 bytes

Lol, the most difficult one-line fix in my life :)

Apparently the repo is using CRLF line-endings for some reason, and I'm not able to create a patch that will apply without converting everything to LF, so posting a patch for the bot and one for review.

marco’s picture

marco commented
Status: Needs review » Reviewed & tested by the community

Reviewed and tested, works well.