Follow up from #2553831: getTargetTypes has expectations that are not being met

Keys from entity_type_ids definitions should be removed as they are not required.

CommentFileSizeAuthor
#2 2554513-fix-etid-definitions.patch6.06 KBdpi

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Parent issue: » #2553831: getTargetTypes has expectations that are not being met
StatusFileSize
new 2554513-fix-etid-definitions.patch6.06 KB

This patch:

  • Removes keys from entity_type_ids definitions.
  • Converts entity_type_ids definitions to short array syntax.
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Assigned: dpi » Unassigned
Category: Task » Bug report
Priority: Minor » Normal
Status: Needs review » Reviewed & tested by the community

Now field.storage_settings.dynamic_entity_reference.entity_type_ids.type is actually a sequence so this is a bug fix.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Fixed
Related issues: +#2318631: Convert entity type checkboxes to multiselect on field settings page

Thanks for the patch and fix.

  • jibran committed 351dae3 on 8.x-1.x authored by dpi 
    Issue #2554513 by dpi: Remove keys from entity_type_ids definitions

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.