The subscription form submit button should be wrapped within the actions wrapper, as is customary on Drupal forms.

See https://api.drupal.org/api/drupal/developer!topics!forms_api_reference.h...

Patch forthcoming...

CommentFileSizeAuthor
#2 mailchimp-submit-actions-wrapper-2554175-2.patch577 bytesjoelstein

Comments

joelstein created an issue. See original summary.

joelstein’s picture

joelstein commented
Status: Active » Needs review
StatusFileSize
new mailchimp-submit-actions-wrapper-2554175-2.patch577 bytes
carsonw’s picture

carsonw
handsome / brilliant
commented
Status: Needs review » Reviewed & tested by the community

+1

  • jami committed c019fe6 on 7.x-3.x authored by joelstein 
    Issue #2554175 by joelstein: Put subscription form submit button inside...
jami’s picture

jami commented
Version: 7.x-3.x-dev » 7.x-3.4
Status: Reviewed & tested by the community » Fixed

Looks good. Applied. Thank you!

joelstein’s picture

joelstein commented

Thanks!

jami’s picture

jami commented
Version: 7.x-3.4 » 7.x-3.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 2: mailchimp-submit-actions-wrapper-2554175-2.patch, failed testing.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Needs work » Fixed
jami’s picture

jami commented
Version: 7.x-3.x-dev » 7.x-3.4

Status: Fixed » Needs review

jami queued 2: mailchimp-submit-actions-wrapper-2554175-2.patch for re-testing.

  • jami committed c019fe6 on 7.x-4.x authored by joelstein 
    Issue #2554175 by joelstein: Put subscription form submit button inside...

  • jami committed c019fe6 on 8.x-1.x authored by joelstein 
    Issue #2554175 by joelstein: Put subscription form submit button inside...
idebr’s picture

idebr commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.