Problem/Motivation
Follow-up to #2338167: Update ProjectInfo class to reflect changes to extension system and #2034879: [Meta] Fix documentation that refers to enabling/disabling of modules
The ProjectInfo class still uses the word disabled when it actually mean uninstalled.
Proposed resolution
Fix it.
Remaining tasks
Write patch
Review
commit
User interface changes
String changes.
API changes
None
Data model changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #26 | interdiff.2553909.11.26.txt | 685 bytes | goz |
| #26 | update_projectinfo-2553909-26.patch | 4.48 KB | goz |
| #23 | interdiff.2553909.11.21-better.txt | 3.32 KB | duaelfr |
| #22 | 2553909-interdiff-11-21.txt | 4.13 KB | goz |
| #21 | update_projectinfo-2553909-21.patch | 6.21 KB | goz |
Comments
Comment #2
alexpottComment #3
pravin ajaaz commented@alexpott: Replaced all disabled with "uninstalled" in the comment blocks
Comment #4
pravin ajaaz commentedTrimmed the line which exceeded 80 characters
Comment #5
duaelfrHi, thank you for your work!
I'd like to apply that patch to review it but I can't.
Can you reroll it please?
While rerolling, please check again that 80 chars limit, I see a lot of comments that are longer.
In case you don't know, we count 80 chars from the beginning of the line, including leading spaces.
Comment #6
deepakaryan1988Comment #7
deepakaryan1988Re-rolled the patch
Comment #8
deepakaryan1988Comment #9
duaelfrThank you @deepakaryan1988 for your reroll.
Source comment has been changed in #2338167: Update ProjectInfo class to reflect changes to extension system.
We should not rewrite that comment again here as it does not mention the "disabled" state anymore.
Can you remove that part of the patch, please?
Comment #10
deepakaryan1988@DuaelFr On it!
Comment #11
deepakaryan1988Re-rolled again!
Comment #12
sudheeshps commentedchanges seems to be fine
Comment #13
duaelfr+1 RTBC
Comment #15
alexpottThis needs changing too... and therefore all the theme functions and any css
Comment #16
deepakaryan1988ok @alexpott but why patch #11 is now failed? Any idea?
Comment #17
duaelfr@deepakaryan1988 RTBC patches are now automatically retested every 24 hours so the code base may have changed since your first submission. In this case it does not seem to be related to the patch so I'll ask the bot to retest your change.
Comment #19
deepakaryan1988@DuaelFr Thanks for the info!!
Comment #20
duaelfrSee #14
Comment #21
goz commentedI found nothing about "disabled" state in css, but delete it in ProjectInfo class and update-project-status theme.
Comment #22
goz commentedComment #23
duaelfrMore readable this way ;)
Comment #26
goz commentedForget my previous patch, patch #11 is the good one.
"Disabled" is confusing. We don't disable modules or themes anymore, but "disabled" name is used in display where "enabled" is used.
See https://www.drupal.org/node/2470145
So i think we have no more things to change after #11 patch, except removing reference to this issue
@Todo Reference to this issue can be removed once this issue is fixed
Comment #27
duaelfr@GoZ what about #15?
Comment #28
goz commentedThis 2 parts of code are used to display uninstalled modules or themes in "Disabled" Area.
The "disabled" term is still used in this case because it's used for screens where "Enabled" term is used and not "Installed".
See https://www.drupal.org/node/2470145 for the discussion about "Disabled" / "Uninstalled" use for those screens.
Comment #29
duaelfrOk it looks good to me.
Let's delay a bit the removal of all the mentions to the "disabled" word so we can ship this tiny fix before the 8.0.0 release.
Comment #30
webchickNice work.
Committed and pushed to 8.0.x. Thanks!