Closed (fixed)
Project:
Translation Management Tool
Version:
8.x-1.x-dev
Component:
Core
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
19 Aug 2015 at 11:13 UTC
Updated:
5 Sep 2015 at 10:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
juanse254 commentedComment #3
juanse254 commentedComment #4
juanse254 commentedThis will fix the tests.
Comment #6
juanse254 commentedokay, this might do it. Its weird but working, feedback apreciated.
Comment #7
juanse254 commentedComment #8
LKS90 commentedI'd suggest only removing the xssFilter() method call.
The test fails that will occur are because the FileTranslator has raw HTML in it's message, which isn't filtered anymore. Fix the broken message in FileTranslator instead of filtering the message you want to use in
drupal_set_message().Edit: Drupal::l() and @link, like in Collect.
Comment #9
juanse254 commentedOkay this way then!.
Comment #11
berdirThis seems to do the trick for me.
Comment #13
berdirDiscussed this with @alexpott, turns out the actual problem were !placeholder's, so lets stop using that. Also, we should call t() even if we have no placeholders, no idea why we don't do that atm.
Comment #14
berdirWrong patch, I think.
Comment #15
berdirAnd, forgot to rename test methods again.
Comment #17
juanse254 commentedSome minor changes you missed, now it should pass.
Comment #18
berdirThanks. Committed.