Move system field.theme.css to Classy

This is re-rolled patch

@maked1sky thanks, I think if you update your git configuration to add the following it will generate a smaller patch:

[diff]
  renames = copies

See https://www.drupal.org/documentation/git/configure

However I think we can simplify this patch.

+++ b/core/modules/system/system.libraries.yml
@@ -27,7 +27,6 @@ base:
-      css/components/field.theme.css: { every_page: true, weight: -10 }

+++ b/core/themes/classy/classy.libraries.yml
@@ -16,6 +16,12 @@ drupal.comment.threaded:
+      css/components/field.css: { weight: -10 }

+++ b/core/themes/classy/templates/field/field--comment.html.twig
@@ -44,6 +44,7 @@
+{{ attach_library('classy/field') }}

If it was every_page before, why change that and add all these attach_library? Just keep it simple, every_page in classy.libraries.yml! :)

For the every_page part see also Lewis' comment in #2553465-4: Move system exposed-filters.theme.css, more-link.theme.css, and pager.theme.css to Classy, he adds some important info (library needs to be added to .info.yml as well).

every_page doesn't exist any more. It was removed from core. Make sure your local repos are up to date. I think it was removed last week.

Regardless of the every_page bit I think we can still attach this via the .info.yml.

We had a bad testbot I'm fairly sure :)

Maybe a silly question but why are we changing markup here? If we revert the change to the template will the tests pass?

I reverted the changes to the template as per the suggestion in #26.

Here are some screenshots from Classy and Bartik to show that they look as they did before. Note that Bartik actually overrides the inline label CSS for tags. Also that float problem with the comments form already exists.

This one looks good.

Needs reroll.

Postponed on: #2566597: [Mega patch] Move system *.theme.css files to Classy

The mega was committed so we don't need this.