Problem/Motivation
See: #2489460: [Meta] Move module.theme.css files to Classy or Seven
Proposed resolution
Move the CSS file to classy
Rename the file to remove the .theme. extension
Alter the system.base library so the CSS file is loaded with a similar weight to before
Remaining tasks
Test steps
Check that the CSS file was deleted from the module and added to Classy
Check that the references to that CSS file removed from the system module
Check that the CSS file is being loaded in the correct places in Classy
Check that there are no HTML classes in the module that relies on the theme CSS
User interface changes
None for Classy, Stark will be more Stark
API changes
None
Beta phase evaluation
Issue category | Task because coding standards |
---|---|
Issue priority | Not critical because coding standards |
Unfrozen changes | Unfrozen because it only changes CSS |
Comment | File | Size | Author |
---|---|---|---|
#28 | Screenshot 2015-09-08 08.45.12.jpg | 835.69 KB | LewisNyman |
#28 | Screenshot 2015-09-08 08.46.26.jpg | 842.54 KB | LewisNyman |
#27 | 2553449-27-move-field-css-classy.patch | 2.55 KB | emma.maria |
Comments
Comment #2
RainbowArrayComment #3
davidhernandezComment #7
maked1sky CreditAttribution: maked1sky commentedThis is re-rolled patch
Comment #8
star-szr@maked1sky thanks, I think if you update your git configuration to add the following it will generate a smaller patch:
See https://www.drupal.org/documentation/git/configure
However I think we can simplify this patch.
If it was every_page before, why change that and add all these attach_library? Just keep it simple, every_page in classy.libraries.yml! :)
Comment #9
star-szrFor the every_page part see also Lewis' comment in #2553465-4: Move system exposed-filters.theme.css, more-link.theme.css, and pager.theme.css to Classy, he adds some important info (library needs to be added to .info.yml as well).
Comment #10
davidhernandezevery_page doesn't exist any more. It was removed from core. Make sure your local repos are up to date. I think it was removed last week.
Comment #11
star-szrRegardless of the every_page bit I think we can still attach this via the .info.yml.
Comment #12
RainbowArrayReroll. There was some weirdness with the field template. Please double-check.
Comment #13
RainbowArrayComment #14
RainbowArrayThis moves field CSS to global-styling, as suggested in #2553465: Move system exposed-filters.theme.css, more-link.theme.css, and pager.theme.css to Classy.
Comment #19
star-szrWe had a bad testbot I'm fairly sure :)
Comment #21
RainbowArrayTrying this on the base library rather than creating a new global-styling library to see if that resolves some of the errors.
Comment #24
RainbowArrayNo need to keep resubmitting these tests. I remember the tests in question from the field markup cleanup, and they're nasty little beasties, because they're entirely dependent on the spacing in the source output. It would be really nice if we could refactor those tests so they still test what they're supposed to test without being so picky.
Comment #26
star-szrMaybe a silly question but why are we changing markup here? If we revert the change to the template will the tests pass?
Comment #27
emma.mariaI reverted the changes to the template as per the suggestion in #26.
Comment #28
LewisNymanHere are some screenshots from Classy and Bartik to show that they look as they did before. Note that Bartik actually overrides the inline label CSS for tags. Also that float problem with the comments form already exists.
Comment #29
davidhernandezThis one looks good.
Comment #30
alexpottNeeds reroll.
Comment #31
LewisNymanPostponed on: #2566597: [Mega patch] Move system *.theme.css files to Classy
Comment #32
davidhernandezThe mega was committed so we don't need this.