Same idea as https://www.drupal.org/node/2465073 for the Captcha module, when Honeypot needs to disable the page cache for the current page, it would be better to call:
drupal_page_is_cacheable(FALSE);
...rather than the way it's currently done by modifying the $conf global:
$GLOBALS['conf']['cache'] = 0;
Apart from anything else, this makes it much easier to work out what's mysteriously disabling page cache on a site.
Patch on the way.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | honeypot-disable_page_cache_via_api-2553319-2.patch | 413 bytes | mcdruid |
Comments
Comment #2
mcdruid commentedComment #3
mcdruid commentedComment #4
geerlingguy commentedTwo thumbs up! I'll merge this fix soon. I'll let the testbot have a go first, of course.
Comment #5
geerlingguy commentedI'll also need to do this for D8, using
\Drupal::service('page_cache_kill_switch')->trigger();; see https://www.drupal.org/node/2323571Comment #7
geerlingguy commentedNeeds to next be ported to D8.
Comment #8
geerlingguy commentedThe D8 work was already done by @justAChris over in #2556233: Disable caching correctly on all forms. Nice! This can be marked as fixed, and I'll backport the new form cache test in the other ticket.